Update CDS manifest generation to include Synapse viewer support #810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the CDS manifest generation logic in FileTable.tsx to include support for Synapse viewers and improved handling of DRS URIs.
- Updated file filtering to include files with either CDS or Synapse viewers
- Adjusted DRS URI generation to use a default Synapse URI when the CDS URI is unavailable
- Added support for mapping viewer names from Synapse viewers
Comments suppressed due to low confidence (1)
packages/data-portal-explore/src/components/FileTable.tsx:98
- The new call to getDrsUri uses a different parameter order (only passing true for removeHostname) compared to the previous invocation (false, true), which may lead to inconsistent URI formatting. Consider using the same parameters as before (i.e. getDrsUri(..., false, true)) or document the change in behavior.
f.viewers?.cds?.drs_uri ? getDrsUri(f.viewers.cds.drs_uri, true) : `drs://repo-prod.prod.sagebase.org/${f.synapseId}`
…egory for Synapse
Contributor
Author
|
Still a work in progress—currently not handling things quite right. I need to refine the modal to clearly differentiate between files that are available from Synapse, available through CDS, and those that have been sent to SB-CGC. Will follow up with a cleanup pass to make those distinctions more explicit. |
…ble for file access types
…ccess methods and cloud compatibility
…trolled and open-access files
…s and cloud compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the logic for generating the CDS manifest file in
FileTable.tsxto include support for Synapse viewers alongside CDS viewers. The change ensures compatibility with Synapse data and improves the handling of DRS URIs.Updates to file viewer filtering and DRS URI handling:
.filtermethod to include files with Synapse viewers in addition to CDS viewers. ([packages/data-portal-explore/src/components/FileTable.tsxL96-R101](https://github.com/ncihtan/htan-portal/pull/810/files#diff-a63573f90ed09072cfc9f384306c5cbe963bda600068d234fd749f4284c80e4eL96-R101))cds.drs_uriis unavailable by constructing a default Synapse DRS URI using thesynapseId. ([packages/data-portal-explore/src/components/FileTable.tsxL96-R101](https://github.com/ncihtan/htan-portal/pull/810/files#diff-a63573f90ed09072cfc9f384306c5cbe963bda600068d234fd749f4284c80e4eL96-R101))[packages/data-portal-explore/src/components/FileTable.tsxL96-R101](https://github.com/ncihtan/htan-portal/pull/810/files#diff-a63573f90ed09072cfc9f384306c5cbe963bda600068d234fd749f4284c80e4eL96-R101))