DRAFT: Raise PhpStan to level 8 #3474
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
May 3, 2025 11:03
> Cannot declare class Neos\Flow\Aop\Exception, because the name is already in use `$exception` in line 64 with the doc type changed to `?\Exception` from `\Exception` is at fault. It seems the expansion from `?\Exception` behaves differently than `\Exception|null` and thus another `class_exist` checks leads to multiple autoloading.
6 tasks
The `array_filter` did not work as expected and should not be necessary - this legacy code just accesses methods that only part of the Package
The check "$maximumAge !== null" must then be dropped because the type can be null > The parameter "maximumAge" passed to the Cookie constructor must be an integer value.
this was last revisited via neos@a456743
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade instructions
None hopefully
Review instructions
Please check whether
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions