Skip to content

DRAFT: Raise PhpStan to level 8 #3474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 61 commits into
base: 10.0
Choose a base branch
from
Draft

Conversation

nezaniel
Copy link
Member

@nezaniel nezaniel commented May 3, 2025

Upgrade instructions

None hopefully

Review instructions

Please check whether

  • all types have been applied correctly
  • all fallback values make sense
  • this can be applied to 9.0 instead of 10

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@github-actions github-actions bot added the 10.0 label May 3, 2025
@nezaniel nezaniel mentioned this pull request May 3, 2025
6 tasks
@nezaniel nezaniel marked this pull request as draft May 3, 2025 10:29
Bernhard Schmitt and others added 10 commits May 3, 2025 13:39
The `array_filter` did not work as expected and should not be necessary - this legacy code just accesses methods that only part of the Package
The check "$maximumAge !== null" must then be dropped because the type can be null

> The parameter "maximumAge" passed to the Cookie constructor must be an integer value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants