Skip to content

DRAFT: Raise PhpStan to level 8 #3474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
nezaniel wants to merge 72 commits into
base: 10.0
Choose a base branch
from
Draft

DRAFT: Raise PhpStan to level 8 #3474

nezaniel wants to merge 72 commits into from

Conversation

@nezaniel
Copy link
Member

@nezaniel nezaniel commented May 3, 2025

Upgrade instructions

None hopefully

Review instructions

Please check whether

  • all types have been applied correctly
  • all fallback values make sense
  • this can be applied to 9.0 instead of 10

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

Bernhard Schmitt added 30 commits May 3, 2025 11:03
WIP: Adjust Neos.Utility.Unicode
efdfb99
Adjust Neos.Utility.Schema
24841c8
Adjust Neos.Utility.Pdo
dc1511e
Adjust Neos.Utility.ObjectHandling
dfda13f
Remove erroneous class check
7438083
Adjust Neos.Utility.MediaTypes
bc1d69e
Adjust Neos.Utility.Files
d065384
Adjust Neos.Utility.Arrays
9cfb4ae
Adjust Neos.Kickstarter
af67fce
Adjust Neos.Http.Factories
cc6955e
Adjust Neos.Http.Factories
756716f
Adjust Neos.FluidAdaptor
326b230
Adjust Neos.Flow.Log
5ae150c
Adjust Neos.Flow Validation subcontext
7f4fc26
Adjust Neos.Flow Utility subcontext
917b5a9
Adjust Neos.Flow SignalSlot subcontext
1127202
Remove erroneous class check
ab3890b
Adjust Neos.Flow Session subcontext
ae5211c
Adjust Neos.Flow Security subcontext
ac89ec0
Adjust Neos.Flow ResourceManagement subcontext
e20d514
Adjust Neos.Flow Reflection subcontext
c04335b
Revert erroneous reflection and class checks
a896aa2
Fix TypeHandling::getTypeForValue
162a294
Adjust Neos.Flow Property subcontext
c9a6a3f
Adjust Neos.Flow Persistence subcontext
7283d5c
Adjust Neos.Flow Package subcontext
46e7383
Adjust Neos.Flow ObjectManagement subcontext
8518eb7
Revert erroneous type check simplifications
1f1fd6e
Adjust Neos.Flow Mvc subcontext
462a3d4
Adjust Neos.Flow Monitor subcontext
dab39e4
@nezaniel nezaniel mentioned this pull request May 3, 2025
Closed
6 tasks
@nezaniel nezaniel marked this pull request as draft May 3, 2025 10:29
Bernhard Schmitt and others added 13 commits May 3, 2025 13:39
Pacify linter for now
d133471
@mhsdesign
PATCH: Apply style CI
62fd9d4
@mhsdesign
PATCH: Apply style CI 2.0
7cda227
@mhsdesign
PATCH: Fix custom testing context auto loading
9a040aa 
The `array_filter` did not work as expected and should not be necessary - this legacy code just accesses methods that only part of the Package
@mhsdesign
PATCH: Fix ScriptsTest
e888328
@mhsdesign
PATCH: Use method->(...) instead of array call syntax for autoloader
ff58ff8
@mhsdesign
PATCH: Remove wrong cookie constructor validation
4464059 
The check "$maximumAge !== null" must then be dropped because the type can be null

> The parameter "maximumAge" passed to the Cookie constructor must be an integer value.
@mhsdesign
PATCH: Allow cookie to have nullable path
2e16a51 
this was last revisited via neos@a456743
@mhsdesign
PATCH: Fix invalid @throws annotations
3112fce
@mhsdesign
PATCH: Document ReflectionService phpstan hack
69df78b
@mficzel
PATCH: Remove unreachable else branch as version is required as strin…
16d8051 
…g argument on method level
@mficzel
PATCH: Remove parameter type that conflicts with interface
6ea0ae8
@mficzel
PATCH: Adjust return type and argument that conflict with UploadedFil…
39704ce 
…eInterface
@mficzel mficzel force-pushed the phpstanLevel8-v2 branch 3 times, most recently from 0e1ef6c to 9cc7ed8 Compare October 24, 2025 10:05
@mficzel mficzel mentioned this pull request Oct 24, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

10.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nezaniel @mhsdesign @mficzel