[BugFix] fix image_ids bug in distributed + packed mode#800
Open
1145284121 wants to merge 1 commit intonerfstudio-project:mainfrom
Open
[BugFix] fix image_ids bug in distributed + packed mode#8001145284121 wants to merge 1 commit intonerfstudio-project:mainfrom
1145284121 wants to merge 1 commit intonerfstudio-project:mainfrom
Conversation
Collaborator
|
Thanks for identifying the bug. however I think the proper fix should be replacing all Explanation: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the bug where image_ids was not updated after sparse_all_to_all operation, causing shape mismatch errors during isect_tiles() in packed mode with multi-GPU training.
Problem Description
Test Command
When running distributed training with packed mode on multiple GPUs, the program crashes during the isect_tiles stage with the following error:
Root Cause
The issue occurs because image_ids is not updated after sparse_all_to_all operation, causing a shape mismatch with other tensors like means2d.
Specifically, codes:
Note
When batch in single rank is not 0, the update of image_ids must also consider batch_ids to ensure correct mapping between images and their corresponding batch indices.