Skip to content

[BugFix] fix image_ids bug in distributed + packed mode #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1145284121 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[BugFix] fix image_ids bug in distributed + packed mode #800

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions gsplat/rendering.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,6 +575,9 @@ def reshape_view(C: int, world_view: torch.Tensor, N_world: list) -> torch.Tenso
output_splits=collected_splits,
)

# image_ids must be updated after sparse_all_to_all, which is used in isect_tiles()
image_ids = camera_ids

# Silently change C from global #Cameras to local #Cameras.
C = C_world[world_rank]

Expand Down