Skip to content

Conversation

@eval-exec
Copy link
Collaborator

This PR want to add lock_code_hash to [multisig_config] in deployment.toml, and let it default to be Multisig Legacy

Also, add comment for sighash, multisig legacy, multisig v1 script info

@eval-exec eval-exec force-pushed the exec/multisig-config-init branch from 59073b7 to 1ceaf54 Compare November 25, 2025 15:17
@eval-exec
Copy link
Collaborator Author

eval-exec commented Nov 25, 2025

Request for review: @sunchengzhu @quake @zhangsoledad @driftluo @XuJiandong

@XuJiandong
Copy link

This is a breaking change. Currently, we can deduce the code_hash from the transaction, as there are only two possible values: legacy or v2.

However, this change would require us to:

  1. Update all existing documents
  2. Update all existing scripts

These updates are unnecessary and should be avoided.

@eval-exec
Copy link
Collaborator Author

This is a breaking change. Currently, we can deduce the code_hash from the transaction, as there are only two possible values: legacy or v2.

However, this change would require us to:

  1. Update all existing documents
  2. Update all existing scripts

These updates are unnecessary and should be avoided.

Fixed by #652

@eval-exec eval-exec closed this Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants