feat: add a protocol to try connecting peers behind firewalls or NAT routers #4766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driftluo
reviewed
Feb 11, 2025
| .support_protocols | ||
| .contains(&SupportProtocol::Penetration) | ||
| { | ||
| let feeler_meta = SupportProtocols::Penetration.build_meta_with_service_handle({ |
Collaborator
There was a problem hiding this comment.
- name typo, it should
penetration_meta build_meta_with_service_handleis not set compress to protocol. does this protocol need to be compressed?
doitian
added a commit
that referenced
this pull request
Jun 6, 2025
feat: add a hole punching protocol try use on nat traversal closes #4824 #4766 This PR introduces a protocol to coordinate node connection behavior, attempting to perform TCP traversal through coordination: 1. Removed the `try dial observe address` behavior. 2. The protocol currently does not support the wasm target and does not support establishing WebSocket protocol connections. 3. The protocol has only three messages, with the following behavior: 1. Schedule finding peer IDs from the peer store that want to establish a connection and broadcasting their possible listening addresses. 2. The node receives a Request message and determines if the target object is itself. 1. If the `to` object is itself, it returns a Delivered message. 2. If the `to` object is not itself, it broadcasts the route and ttl modified. 3. The node receives a Delivered message response. 1. If the `from` object is itself, it starts a TCP connection request and responds with a Sync message 2. If the `from` object is not itself, it modifies the route and ttl and propagates the message to the next router object. 4. The node receives a Sync message response. 1. If the `to` object is itself, it starts a TCP connection request. 2. If the `to` object is not itself, it propagates the message to the next router object. ```mermaid sequenceDiagram participant A as Initiator Node A participant B as Relay Node B participant C as Target Node C autonumber A->>B: ConnectionRequest B->>C: Forward(ConnectionRequest) activate C C-->>C: Validate Target C->>B: ConnectionRequestDelivered (incl. Observed Addr) deactivate C B->>A: Forward(ConnectionRequestDelivered) activate A A-->>A: Process Reply (Store Observed Addr) Note right of A: Delay start early NAT<br/>traversal attempt here (ttl/2) A->>B: ConnectionSync deactivate A B->>C: Forward(ConnectionSync) par Start NAT Traversal & Direct Connection Attempt activate A A-->>A: Start NAT Traversal A-->>C: Direct Connection Attempt (e.g., TCP Hole Punching) deactivate A and activate C C-->>C: Start NAT Traversal C-->>A: Direct Connection Attempt (e.g., TCP Hole Punching) deactivate C end ``` Co-Authored-By: driftluo <[email protected]>
Collaborator
|
closed by #4873 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Add a protocol to try connecting peers behind firewalls or NAT routers.
What is changed and how it works?
To be continued ...
Check List
Tests
Side effects
Release note