feat: add a protocol to try connecting peers behind firewalls or NAT routers #4766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driftluo
reviewed
Feb 11, 2025
| .support_protocols | ||
| .contains(&SupportProtocol::Penetration) | ||
| { | ||
| let feeler_meta = SupportProtocols::Penetration.build_meta_with_service_handle({ |
There was a problem hiding this comment.
- name typo, it should
penetration_meta build_meta_with_service_handleis not set compress to protocol. does this protocol need to be compressed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Add a protocol to try connecting peers behind firewalls or NAT routers.
What is changed and how it works?
To be continued ...
Check List
Tests
Side effects
Release note