fix: Manage Nervos DAO with multisig address#3329
fix: Manage Nervos DAO with multisig address#3329Keith-CY merged 7 commits intonervosnetwork:developfrom
Conversation
|
@Keith-CY Please have a review. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes and enhances the Nervos DAO management when using a multisig address. Key changes include:
- Introducing daoDisabledMessage logic in the multisig address UI to control dialog rendering.
- Refactoring multisig cell fetching by splitting getCells and getLiveCells, and adding a new method (saveMultisigDaoTx) to persist DAO-related transactions.
- Updating cell query filters to restrict output statuses and defining a new constant (DAO_DATA).
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/neuron-ui/src/components/MultisigAddress/index.tsx | Adds daoDisabledMessage logic and displays an AlertDialog when necessary. |
| packages/neuron-wallet/src/services/multisig.ts | Refactors cell fetching and introduces DAO transaction persistence logic. |
| packages/neuron-wallet/src/services/cells.ts | Modifies output status filtering for cell balance calculations. |
| packages/neuron-wallet/src/utils/const.ts | Adds the DAO_DATA constant to support DAO transaction processing. |
Comments suppressed due to low confidence (3)
packages/neuron-ui/src/components/MultisigAddress/index.tsx:220
- [nitpick] Consider renaming 'daoDisabledMessage' to a more descriptive name (e.g. 'daoWarningKey') to better reflect that it holds an i18n message key rather than a boolean flag.
return canSign ? 'dao-ledger-notice' : 'dao-hardware-not-match'
packages/neuron-wallet/src/services/multisig.ts:1
- The method name 'removeDulpicateConfig' contains a typo. Rename it to 'removeDuplicateConfig' for clarity.
private static removeDulpicateConfig(multisigConfigs: MultisigConfig[]) {
packages/neuron-wallet/src/services/cells.ts:1339
- The filter for output statuses was changed from '[OutputStatus.Live, OutputStatus.Sent]' to '[OutputStatus.Live]'. Please confirm that excluding 'Sent' outputs is intentional, as it might omit valid outputs from balance calculations.
statuses: [OutputStatus.Live],
|
/package |
|
1.This package:https://github.com/nervosnetwork/neuron/actions/runs/13893691008 |
fixed @silySuper |
|
/package |


issue:
Screen-2025-03-13-210131.mp4