ci: use runner.os instead of matrix.os in platform conditions#3354
Merged
ci: use runner.os instead of matrix.os in platform conditions#3354
Conversation
runner.os is more general than matrix.os for platform detection
Contributor
There was a problem hiding this comment.
Pull Request Overview
Updates CI workflows to use the runner.os context for platform detection instead of matrix.os, making the OS checks more general and resilient.
- Replaced all
matrix.osconditionals withrunner.osin two workflow files - Ensured consistent OS string comparisons (
Windows,macOS,Linux) across steps
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/package_for_test.yml | Swapped matrix.os checks for runner.os in platform-specific steps |
| .github/workflows/package.yml | Swapped matrix.os checks for runner.os in platform-specific steps |
yanguoyu
approved these changes
May 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
runner.os is more general than matrix.os for platform detection