Skip to content

ci: use runner.os instead of matrix.os in platform conditions #3354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Keith-CY merged 1 commit into from
May 26, 2025
Merged

ci: use runner.os instead of matrix.os in platform conditions #3354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions .github/workflows/package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,19 +50,19 @@ jobs:
key: 2022-12-21-${{ runner.os }}-${{ hashFiles('**/yarn.lock')}}

- name: Add msbuild to PATH
if: matrix.os == 'windows-2019'
if: runner.os == 'Windows'
uses: microsoft/setup-msbuild@v2
env:
ACTIONS_ALLOW_UNSECURE_COMMANDS: "true"

- name: Setup Certificate
if: matrix.os == 'windows-2019'
if: runner.os == 'Windows'
run: |
echo "${{ secrets.SM_CLIENT_CERT_FILE_BASE64 }}" | base64 --decode > /d/Certificate_pkcs12.p12
shell: bash

- name: Set variables
if: matrix.os == 'windows-2019'
if: runner.os == 'Windows'
run: |
echo "SM_KEYPAIR_NAME=${{ secrets.SM_KEYPAIR_ALIAS }}" >> "$GITHUB_ENV"
echo "SM_HOST=${{ secrets.SM_HOST }}" >> "$GITHUB_ENV"
Expand All @@ -75,15 +75,15 @@ jobs:
shell: bash

- name: Setting up the client tools
if: ${{ matrix.os == 'windows-2019' && env.SM_API_KEY != '' }}
if: ${{ runner.os == 'Windows' && env.SM_API_KEY != '' }}
run: |
curl -X GET https://one.digicert.com/signingmanager/api-ui/v1/releases/smtools-windows-x64.msi/download -H "x-api-key:%SM_API_KEY%" -o smtools-windows-x64.msi
msiexec /i smtools-windows-x64.msi /quiet /qn
C:\Windows\System32\certutil.exe -csp "DigiCert Signing Manager KSP" -key -user
shell: cmd

- name: Certificates Sync
if: ${{ matrix.os == 'windows-2019' && env.SM_API_KEY != '' }}
if: ${{ runner.os == 'Windows' && env.SM_API_KEY != '' }}
run: |
smctl windows certsync
shell: cmd
Expand All @@ -109,7 +109,7 @@ jobs:
echo "LOG_ENCRYPTION_PUBLIC_KEY=${{ secrets.LOG_ENCRYPTION_PUBLIC_KEY }}" >> packages/neuron-wallet/.env

- name: Package for MacOS
if: matrix.os == 'macos-latest'
if: runner.os == 'macOS'
run: |
./scripts/download-ckb.sh mac
yarn release mac
Expand All @@ -122,7 +122,7 @@ jobs:
TEAM_ID: ${{ secrets.TEAM_ID }}

- name: Package for Windows
if: matrix.os == 'windows-2019'
if: runner.os == 'Windows'
run: |
bash ./scripts/download-ckb.sh win
yarn build
Expand All @@ -132,50 +132,50 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Package for Linux
if: matrix.os == 'ubuntu-20.04'
if: runner.os == 'Linux'
run: |
./scripts/download-ckb.sh
yarn release linux
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Upload Neuron App Zip
if: matrix.os == 'macos-latest'
if: runner.os == 'macOS'
uses: actions/upload-artifact@v4
with:
name: Neuron-Mac-x64
path: release/Neuron-*-mac-x64.zip

- name: Upload Neuron App Zip(arm64)
if: matrix.os == 'macos-latest'
if: runner.os == 'macOS'
uses: actions/upload-artifact@v4
with:
name: Neuron-Mac-arm64
path: release/Neuron-*-mac-arm64.zip

- name: Upload Neuron Dmg
if: matrix.os == 'macos-latest'
if: runner.os == 'macOS'
uses: actions/upload-artifact@v4
with:
name: Neuron-Dmg-x64
path: release/Neuron-*-x64.dmg

- name: Upload Neuron Dmg(arm64)
if: matrix.os == 'macos-latest'
if: runner.os == 'macOS'
uses: actions/upload-artifact@v4
with:
name: Neuron-Dmg-arm64
path: release/Neuron-*-arm64.dmg

- name: Upload Neuron Win
if: matrix.os == 'windows-2019'
if: runner.os == 'Windows'
uses: actions/upload-artifact@v4
with:
name: Neuron-Win
path: release/Neuron-*-setup.exe

- name: Upload Neuron Linux
if: matrix.os == 'ubuntu-20.04'
if: runner.os == 'Linux'
uses: actions/upload-artifact@v4
with:
name: Neuron-Linux
Expand Down
30 changes: 15 additions & 15 deletions .github/workflows/package_for_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,19 +92,19 @@ jobs:
key: 2022-12-21-${{ runner.os }}-${{ hashFiles('**/yarn.lock')}}

- name: Add msbuild to PATH
if: matrix.os == 'windows-2019'
if: runner.os == 'Windows'
uses: microsoft/setup-msbuild@v2
env:
ACTIONS_ALLOW_UNSECURE_COMMANDS: "true"

- name: Setup Certificate
if: matrix.os == 'windows-2019'
if: runner.os == 'Windows'
run: |
echo "${{ secrets.SM_CLIENT_CERT_FILE_BASE64 }}" | base64 --decode > /d/Certificate_pkcs12.p12
shell: bash

- name: Set variables
if: matrix.os == 'windows-2019'
if: runner.os == 'Windows'
run: |
echo "SM_KEYPAIR_NAME=${{ secrets.SM_KEYPAIR_ALIAS }}" >> "$GITHUB_ENV"
echo "SM_HOST=${{ secrets.SM_HOST }}" >> "$GITHUB_ENV"
Expand All @@ -117,15 +117,15 @@ jobs:
shell: bash

- name: Setting up the client tools
if: ${{ matrix.os == 'windows-2019' && env.SM_API_KEY != '' }}
if: ${{ runner.os == 'Windows' && env.SM_API_KEY != '' }}
run: |
curl -X GET https://one.digicert.com/signingmanager/api-ui/v1/releases/smtools-windows-x64.msi/download -H "x-api-key:%SM_API_KEY%" -o smtools-windows-x64.msi
msiexec /i smtools-windows-x64.msi /quiet /qn
C:\Windows\System32\certutil.exe -csp "DigiCert Signing Manager KSP" -key -user
shell: cmd

- name: Certificates Sync
if: ${{ matrix.os == 'windows-2019' && env.SM_API_KEY != '' }}
if: ${{ runner.os == 'Windows' && env.SM_API_KEY != '' }}
run: |
smctl windows certsync
shell: cmd
Expand Down Expand Up @@ -154,7 +154,7 @@ jobs:
fs.writeFileSync(ympPath, fs.readFileSync(ympPath).toString().replace('asar: true', 'asar: false'))

- name: Package for MacOS
if: ${{ matrix.os == 'macos-latest' && env.MAC_SHOULD_CODE_SIGN == 'true' }}
if: ${{ runner.os == 'macOS' && env.MAC_SHOULD_CODE_SIGN == 'true' }}
run: |
./scripts/download-ckb.sh mac
yarn package:test mac
Expand All @@ -168,7 +168,7 @@ jobs:
USE_HARD_LINKS: false

- name: Package for MacOS for skip code sign
if: ${{ matrix.os == 'macos-latest' && env.MAC_SHOULD_CODE_SIGN == 'false' }}
if: ${{ runner.os == 'macOS' && env.MAC_SHOULD_CODE_SIGN == 'false' }}
run: |
export CSC_IDENTITY_AUTO_DISCOVERY=false
./scripts/download-ckb.sh mac
Expand All @@ -179,7 +179,7 @@ jobs:
USE_HARD_LINKS: false

- name: Package for Windows
if: matrix.os == 'windows-2019'
if: runner.os == 'Windows'
run: |
bash ./scripts/download-ckb.sh win
yarn build
Expand All @@ -189,7 +189,7 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Package for Linux
if: matrix.os == 'ubuntu-20.04'
if: runner.os == 'Linux'
run: |
./scripts/download-ckb.sh
yarn package:test linux
Expand All @@ -198,42 +198,42 @@ jobs:
USE_HARD_LINKS: false

- name: Upload Neuron App Zip
if: matrix.os == 'macos-latest'
if: runner.os == 'macOS'
uses: actions/upload-artifact@v4
with:
name: Neuron-Mac-x64
path: release/Neuron-*-mac-x64.zip

- name: Upload Neuron App Zip(arm64)
if: matrix.os == 'macos-latest'
if: runner.os == 'macOS'
uses: actions/upload-artifact@v4
with:
name: Neuron-Mac-arm64
path: release/Neuron-*-mac-arm64.zip

- name: Upload Neuron Dmg
if: matrix.os == 'macos-latest'
if: runner.os == 'macOS'
uses: actions/upload-artifact@v4
with:
name: Neuron-Dmg-x64
path: release/Neuron-*-x64.dmg

- name: Upload Neuron Dmg(arm64)
if: matrix.os == 'macos-latest'
if: runner.os == 'macOS'
uses: actions/upload-artifact@v4
with:
name: Neuron-Dmg-arm64
path: release/Neuron-*-arm64.dmg

- name: Upload Neuron Win
if: matrix.os == 'windows-2019'
if: runner.os == 'Windows'
uses: actions/upload-artifact@v4
with:
name: Neuron-Win
path: release/Neuron-*-setup.exe

- name: Upload Neuron Linux
if: matrix.os == 'ubuntu-20.04'
if: runner.os == 'Linux'
uses: actions/upload-artifact@v4
with:
name: Neuron-Linux
Expand Down