Skip to content

fix: compatible with "Ledger Nano S+"#3402

Merged
Keith-CY merged 3 commits intonervosnetwork:developfrom
appfi5:develop
Aug 26, 2025
Merged

fix: compatible with "Ledger Nano S+"#3402
Keith-CY merged 3 commits intonervosnetwork:developfrom
appfi5:develop

Conversation

@walker27
Copy link
Collaborator

@walker27 walker27 commented Aug 25, 2025 •
edited
Loading

connect "Ledger Nano S Plus" wallet compatible with product code "Ledger Nano S+", relate issue:#3401

@Keith-CY
Copy link
Collaborator

Keith-CY commented Aug 25, 2025

Please add a description for this PR

@Keith-CY
Copy link
Collaborator

Keith-CY commented Aug 25, 2025 •
edited by github-actions bot
Loading

/package
Packaging for test is done in 17213092273. @Keith-CY

@Keith-CY
Copy link
Collaborator

Keith-CY commented Aug 25, 2025

/package Packaging for test is done in 17213092273. @Keith-CY

Connect and send transaction successfully

@Keith-CY Keith-CY requested a review from Copilot August 26, 2025 06:53
Copilot AI reviewed Aug 26, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds compatibility for the "Ledger Nano S+" hardware wallet by normalizing its product name to "Nano S Plus" for consistent recognition in the Neuron wallet application. Additionally, it fixes a minor spelling error in the UI localization.

  • Adds product name normalization for Ledger Nano S+ devices
  • Fixes spelling error in external node detection dialog

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/neuron-wallet/src/services/hardware/ledger.ts Implements product name mapping from "Nano S+" to "Nano S Plus" for Ledger devices
packages/neuron-ui/src/locales/en.json Corrects spelling from "continu" to "continue" in dialog text

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Keith-CY
Copy link
Collaborator

Keith-CY commented Aug 26, 2025

Please sign future commits

image

Ref: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

@Keith-CY Keith-CY merged commit c946f66 into nervosnetwork:develop Aug 26, 2025
10 checks passed
@Keith-CY Keith-CY mentioned this pull request Aug 26, 2025
Closed
walker27 added a commit that referenced this pull request Jan 6, 2026
@walker27
fix: compatible with "Ledger Nano S+" (#3402)
fed2c2b 
Co-authored-by: zhengzhou <zhengzhou@rivtower.com>
walker27 added a commit that referenced this pull request Jan 7, 2026
@walker27 @devchenyan
@dependabot @github-actions @Keith-CY @yajianggroup @u2
Rc/v0.204.0 (#3431)
a95688e 
* fix: Issues of release v0.201.0 regression testing (#3365)

fix: Issues of release v0.201.0 regression

* chore(deps): bump tar-fs from 2.1.2 to 2.1.3 (#3368)

Bumps [tar-fs](https://github.com/mafintosh/tar-fs) from 2.1.2 to 2.1.3.
- [Commits](https://github.com/mafintosh/tar-fs/commits)

---
updated-dependencies:
- dependency-name: tar-fs
  dependency-version: 2.1.3
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update ckb client versions (#3371)

feat: update ckb client versions

Co-authored-by: Keith-CY <7271329+Keith-CY@users.noreply.github.com>

* feat: Identify and prompt for multisig transaction (#3370)

* feat: Identify and prompt for multisig transaction

* fix: error message

* fix: Full node in mainnet can not change data path (#3382)

* chore(deps): bump pbkdf2 from 3.1.2 to 3.1.3 (#3379)

Bumps [pbkdf2](https://github.com/crypto-browserify/pbkdf2) from 3.1.2 to 3.1.3.
- [Changelog](https://github.com/browserify/pbkdf2/blob/master/CHANGELOG.md)
- [Commits](browserify/pbkdf2@v3.1.2...v3.1.3)

---
updated-dependencies:
- dependency-name: pbkdf2
  dependency-version: 3.1.3
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: Optimize receive address handling for hardware wallets (#3394)

* fix: compatible with  "Ledger Nano S+" (#3402)

Co-authored-by: zhengzhou <zhengzhou@rivtower.com>

* Update ckb client versions (#3403)

feat: update ckb client versions

Co-authored-by: Keith-CY <7271329+Keith-CY@users.noreply.github.com>

* chore(deps-dev): bump electron from 36.6.0 to 36.8.1 in /packages/neuron-ui (#3404)

chore(deps-dev): bump electron in /packages/neuron-ui

Bumps [electron](https://github.com/electron/electron) from 36.6.0 to 36.8.1.
- [Release notes](https://github.com/electron/electron/releases)
- [Changelog](https://github.com/electron/electron/blob/main/docs/breaking-changes.md)
- [Commits](electron/electron@v36.6.0...v36.8.1)

---
updated-dependencies:
- dependency-name: electron
  dependency-version: 36.8.1
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps-dev): bump electron from 36.6.0 to 36.8.1 in /packages/neuron-wallet (#3405)

chore(deps-dev): bump electron in /packages/neuron-wallet

Bumps [electron](https://github.com/electron/electron) from 36.6.0 to 36.8.1.
- [Release notes](https://github.com/electron/electron/releases)
- [Changelog](https://github.com/electron/electron/blob/main/docs/breaking-changes.md)
- [Commits](electron/electron@v36.6.0...v36.8.1)

---
updated-dependencies:
- dependency-name: electron
  dependency-version: 36.8.1
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump sha.js from 2.4.11 to 2.4.12 (#3406)

Bumps [sha.js](https://github.com/crypto-browserify/sha.js) from 2.4.11 to 2.4.12.
- [Changelog](https://github.com/browserify/sha.js/blob/master/CHANGELOG.md)
- [Commits](browserify/sha.js@v2.4.11...v2.4.12)

---
updated-dependencies:
- dependency-name: sha.js
  dependency-version: 2.4.12
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update ckb client versions (#3408)

feat: update ckb client versions

Co-authored-by: Keith-CY <7271329+Keith-CY@users.noreply.github.com>

* chore(deps-dev): bump vite from 6.2.7 to 6.3.6 (#3409)

Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 6.2.7 to 6.3.6.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v6.3.6/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v6.3.6/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-version: 6.3.6
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update bug_report.yml

change default assignees

* Update ckb client versions (#3416)

feat: update ckb client versions

Co-authored-by: Keith-CY <7271329+Keith-CY@users.noreply.github.com>

* chore: remove font ProximaNova

* fix: spell fix

* chore: fix github actions node version

* Update ckb client versions (#3422)

feat: update ckb client versions

Co-authored-by: Keith-CY <7271329+Keith-CY@users.noreply.github.com>

* chore: fix broken url (#3413)

Signed-off-by: yajianggroup <yajianggroup@outlook.com>
Co-authored-by: zhangyaning <zhangyaning1985@gmail.com>
Co-authored-by: 郑州 <wzszhengzhou@hotmail.com>

* chore: update AppId (#3426)

* chore(deps): bump qs from 6.14.0 to 6.14.1 (#3425)

Bumps [qs](https://github.com/ljharb/qs) from 6.14.0 to 6.14.1.
- [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md)
- [Commits](ljharb/qs@v6.14.0...v6.14.1)

---
updated-dependencies:
- dependency-name: qs
  dependency-version: 6.14.1
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: 郑州 <wzszhengzhou@hotmail.com>

* chore(deps): bump tar-fs from 2.1.3 to 2.1.4 (#3412)

Bumps [tar-fs](https://github.com/mafintosh/tar-fs) from 2.1.3 to 2.1.4.
- [Commits](mafintosh/tar-fs@v2.1.3...v2.1.4)

---
updated-dependencies:
- dependency-name: tar-fs
  dependency-version: 2.1.4
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: update neuron version

* chore: Update ckb node assume valid target (#3428)

chore: Update ckb node assume valid target for rc/v0.204.0.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update ckb client versions (#3429) (#3430)

feat: update ckb client versions

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Keith-CY <7271329+Keith-CY@users.noreply.github.com>

* chore: update CHANGELOG

* chore: update CHANGELOG

* chore: update CHANGELOG

---------

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: yajianggroup <yajianggroup@outlook.com>
Co-authored-by: devchenyan <sgt39007@163.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Keith-CY <7271329+Keith-CY@users.noreply.github.com>
Co-authored-by: zhengzhou <zhengzhou@rivtower.com>
Co-authored-by: yajianggroup <yajianggroup@outlook.com>
Co-authored-by: zhangyaning <zhangyaning1985@gmail.com>
github-merge-queue bot pushed a commit that referenced this pull request Jan 12, 2026
@github-actions @walker27
@devchenyan @dependabot @Keith-CY @yajianggroup @u2
Merge released refs/tags/v0.204.0 into develop (#3435)
b0998f3 
Rc/v0.204.0 (#3431)

* fix: Issues of release v0.201.0 regression testing (#3365)

fix: Issues of release v0.201.0 regression

* chore(deps): bump tar-fs from 2.1.2 to 2.1.3 (#3368)

Bumps [tar-fs](https://github.com/mafintosh/tar-fs) from 2.1.2 to 2.1.3.
- [Commits](https://github.com/mafintosh/tar-fs/commits)

---
updated-dependencies:
- dependency-name: tar-fs
  dependency-version: 2.1.3
  dependency-type: indirect
...




* Update ckb client versions (#3371)

feat: update ckb client versions



* feat: Identify and prompt for multisig transaction (#3370)

* feat: Identify and prompt for multisig transaction

* fix: error message

* fix: Full node in mainnet can not change data path (#3382)

* chore(deps): bump pbkdf2 from 3.1.2 to 3.1.3 (#3379)

Bumps [pbkdf2](https://github.com/crypto-browserify/pbkdf2) from 3.1.2 to 3.1.3.
- [Changelog](https://github.com/browserify/pbkdf2/blob/master/CHANGELOG.md)
- [Commits](browserify/pbkdf2@v3.1.2...v3.1.3)

---
updated-dependencies:
- dependency-name: pbkdf2
  dependency-version: 3.1.3
  dependency-type: indirect
...




* feat: Optimize receive address handling for hardware wallets (#3394)

* fix: compatible with  "Ledger Nano S+" (#3402)



* Update ckb client versions (#3403)

feat: update ckb client versions



* chore(deps-dev): bump electron from 36.6.0 to 36.8.1 in /packages/neuron-ui (#3404)

chore(deps-dev): bump electron in /packages/neuron-ui

Bumps [electron](https://github.com/electron/electron) from 36.6.0 to 36.8.1.
- [Release notes](https://github.com/electron/electron/releases)
- [Changelog](https://github.com/electron/electron/blob/main/docs/breaking-changes.md)
- [Commits](electron/electron@v36.6.0...v36.8.1)

---
updated-dependencies:
- dependency-name: electron
  dependency-version: 36.8.1
  dependency-type: direct:development
...




* chore(deps-dev): bump electron from 36.6.0 to 36.8.1 in /packages/neuron-wallet (#3405)

chore(deps-dev): bump electron in /packages/neuron-wallet

Bumps [electron](https://github.com/electron/electron) from 36.6.0 to 36.8.1.
- [Release notes](https://github.com/electron/electron/releases)
- [Changelog](https://github.com/electron/electron/blob/main/docs/breaking-changes.md)
- [Commits](electron/electron@v36.6.0...v36.8.1)

---
updated-dependencies:
- dependency-name: electron
  dependency-version: 36.8.1
  dependency-type: direct:development
...




* chore(deps): bump sha.js from 2.4.11 to 2.4.12 (#3406)

Bumps [sha.js](https://github.com/crypto-browserify/sha.js) from 2.4.11 to 2.4.12.
- [Changelog](https://github.com/browserify/sha.js/blob/master/CHANGELOG.md)
- [Commits](browserify/sha.js@v2.4.11...v2.4.12)

---
updated-dependencies:
- dependency-name: sha.js
  dependency-version: 2.4.12
  dependency-type: indirect
...




* Update ckb client versions (#3408)

feat: update ckb client versions



* chore(deps-dev): bump vite from 6.2.7 to 6.3.6 (#3409)

Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 6.2.7 to 6.3.6.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v6.3.6/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v6.3.6/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-version: 6.3.6
  dependency-type: direct:development
...




* Update bug_report.yml

change default assignees

* Update ckb client versions (#3416)

feat: update ckb client versions



* chore: remove font ProximaNova

* fix: spell fix

* chore: fix github actions node version

* Update ckb client versions (#3422)

feat: update ckb client versions



* chore: fix broken url (#3413)





* chore: update AppId (#3426)

* chore(deps): bump qs from 6.14.0 to 6.14.1 (#3425)

Bumps [qs](https://github.com/ljharb/qs) from 6.14.0 to 6.14.1.
- [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md)
- [Commits](ljharb/qs@v6.14.0...v6.14.1)

---
updated-dependencies:
- dependency-name: qs
  dependency-version: 6.14.1
  dependency-type: indirect
...





* chore(deps): bump tar-fs from 2.1.3 to 2.1.4 (#3412)

Bumps [tar-fs](https://github.com/mafintosh/tar-fs) from 2.1.3 to 2.1.4.
- [Commits](mafintosh/tar-fs@v2.1.3...v2.1.4)

---
updated-dependencies:
- dependency-name: tar-fs
  dependency-version: 2.1.4
  dependency-type: indirect
...




* chore: update neuron version

* chore: Update ckb node assume valid target (#3428)

chore: Update ckb node assume valid target for rc/v0.204.0.



* Update ckb client versions (#3429) (#3430)

feat: update ckb client versions




* chore: update CHANGELOG

* chore: update CHANGELOG

* chore: update CHANGELOG

---------

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: yajianggroup <yajianggroup@outlook.com>
Co-authored-by: 郑州 <wzszhengzhou@hotmail.com>
Co-authored-by: devchenyan <sgt39007@163.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Keith-CY <7271329+Keith-CY@users.noreply.github.com>
Co-authored-by: zhengzhou <zhengzhou@rivtower.com>
Co-authored-by: yajianggroup <yajianggroup@outlook.com>
Co-authored-by: zhangyaning <zhangyaning1985@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@Keith-CY Keith-CY Keith-CY approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@walker27 @Keith-CY