Skip to content

fix: compatible with "Ledger Nano S+" #3402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Keith-CY merged 3 commits into from
Aug 26, 2025
Merged

fix: compatible with "Ledger Nano S+" #3402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f326f1c
fix: compatible with "Ledger Nano S+"
Aug 25, 2025
56ba1b3
fix: lint fix
Aug 25, 2025
f9aef11
fix: spell fix
Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/neuron-ui/src/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1282,7 +1282,7 @@
"external-node-detected-dialog": {
"title": "Detected external node",
"body-tips-without-network": "You have selected the internal node but started the external node, if you want to continue to use an external node, please add a new network.",
"body-tips-with-network": "You have currently selected an internal node but started an external node, if you need to continu using the external node please switch to another external network or add a new network.",
"body-tips-with-network": "You have currently selected an internal node but started an external node, if you need to continue using the external node please switch to another external network or add a new network.",
"add-network": "Add Network",
"ignore-external-node": "Ignore external node"
},
Expand Down
6 changes: 5 additions & 1 deletion packages/neuron-wallet/src/services/hardware/ledger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,14 +153,18 @@ export default class Ledger extends Hardware {
takeUntil(timer(2000)),
filter<DescriptorEvent<any>>(e => e.type === 'add'),
scan<DescriptorEvent<any>, DeviceInfo[]>((acc, e) => {
let product = e.device.product
if (e.device.manufacturer === 'Ledger' && product === 'Nano S+') {
product = 'Nano S Plus'
}
return [
...acc,
{
isBluetooth,
descriptor: e.descriptor,
vendorId: e.device.vendorId,
manufacturer: e.device.manufacturer,
product: e.device.product,
product,
addressIndex: 0,
addressType: hd.AddressType.Receiving,
},
Expand Down
Loading