Refactor ApplicationFactory#64
Open
angelsanzn wants to merge 3 commits into
Open
Conversation
added 3 commits
December 3, 2015 13:56
It isn't being used anywhere.
…tings_` This uses a namespaced import to avoid creating a local variable 'settings' with the import statement, which was the reason why a trailing slash was used to avoid shadowing that variable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are some minor changes that occurred to me when reading the code.
I understand that you might not like the "namespaced import" (
from mamba.settings ...) because it differentiates between importing settings and importing almost everything else, and because the importing style through the code mostly avoids "namespaced imports", in favour of explicit attribute lookup in the imported names.I personally prefer importing only what I need from my own modules (but usually not from buillt-in modules), especially when most modules are actually exposing a single class or two.
Anyway, tell me what you think 😉