Skip to content

Refactor ApplicationFactory #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
angelsanzn wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Refactor ApplicationFactory #64

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f99c9c
ApplicationFactory: remove unused private `_instances` field
Dec 3, 2015
558b6aa
ApplicationFactory: remove trailing slash in local variable name `set…
Dec 3, 2015
f16cc5e
ApplicationFactory: mark `arguments` field as private
Dec 3, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions mamba/application_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,26 +1,26 @@
# -*- coding: utf-8 -*-

from mamba import settings, formatters, reporter, runners, example_collector, loader
from mamba import formatters, reporter, runners, example_collector, loader
from mamba.settings import Settings
from mamba.infrastructure import is_python3


class ApplicationFactory(object):

def __init__(self, arguments):
self._instances = {}
self.arguments = arguments
self._arguments = arguments

def create_settings(self):
settings_ = settings.Settings()
settings_.slow_test_threshold = self.arguments.slow
settings_.enable_code_coverage = self.arguments.enable_coverage
settings_.format = self.arguments.format
settings_.no_color = self.arguments.no_color
settings = Settings()
settings.slow_test_threshold = self._arguments.slow
settings.enable_code_coverage = self._arguments.enable_coverage
settings.format = self._arguments.format
settings.no_color = self._arguments.no_color

if not is_python3():
settings_.enable_file_watcher = self.arguments.watch
settings.enable_file_watcher = self._arguments.watch

return settings_
return settings

def create_formatter(self):
settings = self.create_settings()
Expand All @@ -29,7 +29,7 @@ def create_formatter(self):
return formatters.ProgressFormatter(settings)

def create_example_collector(self):
return example_collector.ExampleCollector(self.arguments.specs)
return example_collector.ExampleCollector(self._arguments.specs)

def create_reporter(self):
return reporter.Reporter(self.create_formatter())
Expand Down