Open
Conversation
Contributor
|
This pull request adds or modifies JavaScript ( |
8f75c53 to
6aacbaa
Compare
6aacbaa to
250dfc0
Compare
9d2571b to
8390726
Compare
7f4ab11 to
40f477b
Compare
serhalp
reviewed
Jan 26, 2026
Member
serhalp
left a comment
There was a problem hiding this comment.
Great finds! I have some thoughts/questions inline
c95ce28 to
ab778ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Testing fixes. No ticket/linear issue but these changes were prompted from discussions about CLI here:
https://netlify.slack.com/archives/C096B91TE03/p1769180475717899
https://netlify.slack.com/archives/C096B91TE03/p1769124255667039
Fix #1:
Changed test() to test.serial() for the
"build plugins can manipulate netlifyToml.edge_functions array"test.Both the default and tarball tests were running concurrently and writing to the same fixture directory :-/ this was causing some seemingly random failures since one test's bundle files would be overwritten by the other.
Fix #2:
Increased SERVER_POLL_TIMEOUT from 10s to 30s. The Deno server spinning up time in CI can be slower due to limited resources, causing the waitForServer() polling to timeout before the server is ready. This was causing flaky failures in server.test.ts.
Fix #3:
Added caching for downloaded Deno binaries (
~/.netlify/deno-cliand~/.netlify/deno-cli-v1) in the CI workflowThis is to prevent re-downloading Deno binaries on every CI run
Cache key includes a hash of bridge.ts to automatically invalidate when version changes.
Fix #4: Network Error Retries
Added p-retry dependency to netlify/config for retrying extension fetching on transient network errors. Follows existing pattern from
packages/edge-bundler/node/downloader.test.tswhich uses p-retry with vi.mock() to speed up retry tests by reducing timeouts from seconds to milliseconds.For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
your code follows our style guide and passes our tests.
A picture of a cute animal (not mandatory, but encouraged)