fix(GetEnvTool): accept int keys from getenv() and apply rector/cgl migrations - #885
Open
CybotTM wants to merge 2 commits into
Open
fix(GetEnvTool): accept int keys from getenv() and apply rector/cgl migrations#885CybotTM wants to merge 2 commits into
CybotTM wants to merge 2 commits into
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
github-actions
Bot
added
documentation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Automated approval for maintainer PR
All automated quality gates passed. See SECURITY_CONTROLS.md for compensating controls.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #885 +/- ##
============================================
- Coverage 87.61% 87.49% -0.13%
Complexity 10057 10057
============================================
Files 577 577
Lines 32691 32686 -5
============================================
- Hits 28641 28597 -44
- Misses 4050 4089 +39
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…igrations - GetEnvTool::maskValue(): accept string|int for $name (getenv() may return integer keys in some environments) - Apply Rector migrations: expectExceptionMessage -> expectExceptionMessageIsOrContains for PHPUnit 12+ compatibility (59 files) - Fix PHP-CS-Fixer import ordering in 9 test files - Update Tests/AGENTS.md: fix e2e command format Closes: #885 Signed-off-by: Sebastian Mendel <sebastian.mendel@netresearch.de> Assisted-by: sisyphus:nemotron-3-ultra-free Agent-Session: https://opencode.ai/session/placeholder Agent-Host: 0493f0
… case - foreach $env as $name: add @var string annotation for PHPStan - maskValue(): keep string type, cast to string internally for safety - Comment explains getenv() edge case Closes: #885 Signed-off-by: Sebastian Mendel <sebastian.mendel@netresearch.de> Assisted-by: sisyphus:nemotron-3-ultra-free Agent-Session: opencode-session Agent-Host: 0493f0
CybotTM
force-pushed
the
fix-getenv-tool
branch
from
August 27, 2026 12:37
58a7f99 to
685ca9c
Compare
Contributor
There was a problem hiding this comment.
Automated approval for maintainer PR
All automated quality gates passed. See SECURITY_CONTROLS.md for compensating controls.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(GetEnvTool): accept int keys from getenv() and apply rector/cgl migrations
integer keys in some environments)
for PHPUnit 12+ compatibility (59 files)
Closes: #885
Signed-off-by: Sebastian Mendel sebastian.mendel@netresearch.de
Assisted-by: claude-code:opencode/nemotron-3-ultra-free
Agent-Session: https://claude.ai/code/session_placeholder
Agent-Host: 0493f0