ExternalProject SUNDIALS 3.2.1 - #1960
Open
alexsavulescu wants to merge 136 commits into
Open
Conversation
* include work from cvode3 branch
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
|
@alkino Just to let you know, I have a fix for |
Member
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
✔️ d38be72 -> Azure artifacts URL |
|
|
✔️ 091c5c0 -> Azure artifacts URL |
Collaborator
Conflicts: docs/python/simctrl/cvode.rst test/cover/test_netcvode.py test/external/CMakeLists.txt test/pytest_coreneuron/test_nrntest_fast.py test/rxd/testdata
- Use keyword signatures consistently in target_link_libraries - Make SUNDIALS include directory PRIVATE + BUILD_INTERFACE only
The SUNDIALS library is now provided via CMake submodule (external/sundials). The src/sundials directory is no longer needed.
- Add external/sundials submodule pointing to neuronsimulator/sundials (hines/hoc_pow) - Update FindSUNDIALS.cmake to use the standard submodule approach. - Build SUNDIALS inside the main build directory. - Initialization consistent with other submodules (InterViews, etc.)
Matches formatting used in CI (Python 3.10.12 + black 22.12.0).
- Support both 'main' and 'master' as base branch - Only pass existing files to the formatter - Eliminates noisy "ERROR: X jobs failed" when files were deleted
* see test/rxd/compare_rxd_testdata_dirs.py -h
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| "\nClose the matplot window to continue to next pair (or Ctrl+C to stop)..." | ||
| ) | ||
| try: | ||
| subprocess.run(cmd, check=True) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1328