Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Draft for feb release]feat: Predictive alerts for PP #19853

Merged
merged 20 commits into from
Feb 25, 2025
Merged

[Draft for feb release]feat: Predictive alerts for PP #19853

merged 20 commits into from
Feb 25, 2025

Conversation

sujitnewrelic
Copy link
Contributor

Do not merge! Feb release draft.

@sujitnewrelic sujitnewrelic added content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers labels Jan 30, 2025
@sujitnewrelic sujitnewrelic self-assigned this Jan 30, 2025
@github-actions GitHub Actions
Copy link

Hi @sujitnewrelic 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes).

@netlify Netlify
Copy link

netlify bot commented Jan 30, 2025 •
edited
Loading

✅ Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit 7ebb892
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/67bc7ec71104f4000823b212
😎 Deploy Preview https://deploy-preview-19853--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sujitnewrelic sujitnewrelic marked this pull request as ready for review February 7, 2025 04:49
vpayyapilly
vpayyapilly reviewed Feb 10, 2025
View reviewed changes
src/content/docs/alerts/create-alert/set-thresholds/predictive-alerts.mdx Outdated

#### To edit an existing alert condition:
1. Select an alert condition from <DNT>**[one.newrelic.com > All capabilities](https://one.newrelic.com/all-capabilities) > Alerts > Alert Conditions**</DNT>, and edit the <DNT>**Signal behavior**</DNT>.
2. From the <DNT>**Signal behavior**</DNT> section, click <DNT>**Edit**</DNT>. the <DNT>**Set thresholds**</DNT> page opens.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. From the <DNT>**Signal behavior**</DNT> section, click <DNT>**Edit**</DNT>. the <DNT>**Set thresholds**</DNT> page opens.
2. From the <DNT>**Signal behavior**</DNT> section, click <DNT>**Edit**</DNT>. The <DNT>**Set thresholds**</DNT> page opens.

vpayyapilly
vpayyapilly requested changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@vpayyapilly vpayyapilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix and resubmit.

vpayyapilly
vpayyapilly previously approved these changes Feb 17, 2025
View reviewed changes
@sujitnewrelic sujitnewrelic marked this pull request as draft February 18, 2025 04:37
@kimberlyburns
Copy link
Contributor

Hi all, sorry about a last minute change request. We need to add a clarification about how much data is taken into consideration for training the model for the predictive alert in the Predictive Alerts doc here

We mention that the longer the window duration, the farther ahead we can look. We also need to mention that the same applies to how far back we can look to train the model on previous data. We can look back 2.5 days with a one-minute granularity, and that amount of lookback time increases in proportion to the window size.

@cbehera-newrelic cbehera-newrelic marked this pull request as ready for review February 25, 2025 05:20
@cbehera-newrelic cbehera-newrelic requested review from cbehera-newrelic and removed request for adutta-newrelic February 25, 2025 05:20
cbehera-newrelic
cbehera-newrelic approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@cbehera-newrelic cbehera-newrelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbehera-newrelic cbehera-newrelic merged commit 15621f5 into develop Feb 25, 2025
19 checks passed
@cbehera-newrelic cbehera-newrelic deleted the predictive-alert branch February 25, 2025 05:21
sujitnewrelic added a commit that referenced this pull request Feb 25, 2025
@sujitnewrelic
chore(Fed release item): spell check and link correction
592b2cf 
Final check corrections of the following PR:

#19667
#19933
#19853
#20055
#19937 (Only Maps part)
@sujitnewrelic sujitnewrelic mentioned this pull request Feb 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbehera-newrelic cbehera-newrelic cbehera-newrelic approved these changes

@vpayyapilly vpayyapilly vpayyapilly left review comments

Assignees

@sujitnewrelic sujitnewrelic

Labels
content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sujitnewrelic @kimberlyburns @cbehera-newrelic @vpayyapilly