NR-347971 | OpenLineage event consumer writer #1887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
entityBot
approved these changes
Jan 30, 2025
|
|
entityBot
approved these changes
Jan 30, 2025
devendra-nr
changed the title
entityBot
approved these changes
Jan 30, 2025
entityBot
approved these changes
Jan 30, 2025
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
entityBot
approved these changes
Feb 2, 2025
entityBot
approved these changes
Feb 2, 2025
entityBot
approved these changes
Feb 2, 2025
entityBot
approved these changes
Feb 2, 2025
entityBot
approved these changes
Feb 2, 2025
entityBot
approved these changes
Feb 2, 2025
NR-347971 | Added filter condition on unique attribute
| - updatedAt | ||
| name: job.name | ||
| encodeIdentifierInGUID: true | ||
| conditions: |
There was a problem hiding this comment.
It looks like the conditions for this definition are the same ones than for OLIN_JOBS. The conditions should have some differentiation to avoid collisions
There was a problem hiding this comment.
I have added following condition to differentiate between events since the updatedAt field should be present only in OLIN_JOB_VERSIONS. Is this sufficient?
#OLIN_JOBS
- attribute: updatedAt
present: false
#OLIN_JOB_VERSIONS
- attribute: updatedAt
present: true
I have written similar conditions for OLIN_DATASETS vs OLIN_DATASET_VERSIONS
nr-cmorenoin
approved these changes
Feb 28, 2025
|
To be merged after the freeze window |
otaviocarvalho
added a commit
that referenced
this pull request
Mar 6, 2025
This reverts commit 7c9f7fc.
apoloa
added a commit
that referenced
this pull request
Mar 11, 2025
This reverts commit 7c9f7fc. Co-authored-by: Adrian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant information
Added domain and entities for Data Pipeline Observability product
Checklist
identifierwill be unique and valid.