-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NR-347971 | OpenLineage event consumer writer #1887
Merged
otaviocarvalho
merged 44 commits into
newrelic:main
from
devendra-nr:NR-347971-OLIN-event-consumer-writer
Mar 3, 2025
Merged
Changes from all commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
e5ee948
OLIN agent collection
devendra-nr 234692f
Create DPO collections
devendra-nr 03ad233
NR-347971 OLIN agent collection
devendra-nr 8cf86d2
NR-347971 | Added identifiers and tags
devendra-nr 9680c79
Merge branch 'main' into NR-347971-OLIN-event-consumer-writer
devendra-nr 19db55c
Merge branch 'main' into NR-347971-OLIN-event-consumer-writer
devendra-nr b872e62
NR=347971 Update name as per OLIN spec
devendra-nr d654b44
NR-347971 Revert file change
devendra-nr 744128d
NR-347971 | Use unique tag names
devendra-nr addf09f
Merge branch 'newrelic:main' into NR-347971-OLIN-event-consumer-writer
devendra-nr 2ed1250
NR-347971 | Added conditions
devendra-nr a2677a6
NR-347971 | Added conditions
devendra-nr ca95fe5
Merge branch 'newrelic:main' into NR-347971-OLIN-event-consumer-writer
devendra-nr 9dbe0dc
NR-347871 | Remove redundant line
devendra-nr 16814aa
Merge pull request #2 from devendra-nr/NR-347971-add-condition
devendra-nr ca9750d
Merge branch 'main' into NR-347971-OLIN-event-consumer-writer
devendra-nr 1197390
Merge branch 'main' into NR-347971-OLIN-event-consumer-writer
devendra-nr fc6f648
Merge branch 'main' into NR-347971-OLIN-event-consumer-writer
devendra-nr ed516e4
Merge branch 'main' into NR-347971-OLIN-event-consumer-writer
devendra-nr f69d9b6
Merge branch 'main' into NR-347971-OLIN-event-consumer-writer
devendra-nr 5caa6c4
Added test case
devendra-nr a2624f2
Added more entity conditions
devendra-nr fba7ca4
Update test data
devendra-nr a3f0e5d
Merge branch 'main' into NR-347971-add-condition
devendra-nr 1e6be59
Added entity type to test data
devendra-nr 97b0286
Merge branch 'NR-347971-add-condition' of https://github.com/devendra…
devendra-nr e081da9
Merge branch 'main' into NR-347971-OLIN-event-consumer-writer
devendra-nr 6f28171
Merge branch 'NR-347971-OLIN-event-consumer-writer' into NR-347971-ad…
devendra-nr 56e12c8
Merge pull request #4 from devendra-nr/NR-347971-add-condition
devendra-nr e269c47
Update testcase
devendra-nr 03640a6
Merge branch 'NR-347971-add-condition' of https://github.com/devendra…
devendra-nr 0f2b23a
Merge pull request #5 from devendra-nr/NR-347971-add-condition
devendra-nr 2604e18
Update test
devendra-nr 910ded8
Merge pull request #6 from devendra-nr/NR-347971-add-condition
devendra-nr 07cebf9
Update type
devendra-nr b83e0a2
Merge pull request #7 from devendra-nr/NR-347971-add-condition
devendra-nr 644b20a
Update type
devendra-nr ad540bc
Merge pull request #8 from devendra-nr/NR-347971-add-condition
devendra-nr 55a3573
Merge branch 'main' into NR-347971-OLIN-event-consumer-writer
devendra-nr cc70a51
Merge branch 'main' into NR-347971-OLIN-event-consumer-writer
devendra-nr e61ef7a
NR-347971 add filter condition
devendra-nr ed311d1
NR-347971 add filter condition
devendra-nr 2dbc3d2
Merge pull request #9 from devendra-nr/NR-347971-add-condition
devendra-nr c9bdc56
Merge branch 'main' into NR-347971-OLIN-event-consumer-writer
devendra-nr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| domain: AGENT | ||
| type: OLIN | ||
| configuration: | ||
| entityExpirationTime: MANUAL | ||
| alertable: false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| domain: DPO | ||
| type: OLIN_DATASET_VERSIONS | ||
| synthesis: | ||
| rules: | ||
| - compositeIdentifier: | ||
| separator: ":" | ||
| attributes: | ||
| - dataset.namespace | ||
| - dataset.name | ||
| - updatedAt | ||
| name: dataset.name | ||
| encodeIdentifierInGUID: true | ||
| conditions: | ||
| - attribute: newrelic.entity.type | ||
| value: DPO | ||
| - attribute: eventTime | ||
| present: true | ||
| - attribute: updatedAt | ||
| present: true | ||
| - attribute: producer | ||
| present: true | ||
| - attribute: schemaURL | ||
| present: true | ||
| - attribute: dataset.namespace | ||
| present: true | ||
| - attribute: dataset.name | ||
| present: true | ||
| tags: | ||
| dataset.namespace: | ||
| entityTagName: olin.dataset.namespace | ||
| multiValue: false | ||
| dataset.name: | ||
| entityTagName: olin.dataset.name | ||
| multiValue: false | ||
| dataset.updatedAt: | ||
| entityTagName: olin.dataset.updatedAt | ||
| multiValue: false | ||
| configuration: | ||
| entityExpirationTime: MANUAL | ||
| alertable: true |
11 changes: 11 additions & 0 deletions
11
entity-types/dpo-olin_dataset_versions/tests/datasetversions.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| [ | ||
| { | ||
| "newrelic.entity.type": "DPO", | ||
| "eventTime": "2019-08-24T14:15:22Z", | ||
| "updatedAt": "2019-08-24T14:15:22Z", | ||
| "producer": "https://github.com/OpenLineage/OpenLineage/blob/v1-0-0/client", | ||
| "schemaURL": "https://openlineage.io/spec/0-0-1/OpenLineage.json", | ||
| "dataset.namespace": "my-datasource-namespace", | ||
| "dataset.name": "instance.schema.table" | ||
| } | ||
| ] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| domain: DPO | ||
| type: OLIN_DATASETS | ||
| synthesis: | ||
| rules: | ||
| - compositeIdentifier: | ||
| separator: ":" | ||
| attributes: | ||
| - dataset.namespace | ||
| - dataset.name | ||
| name: dataset.name | ||
| encodeIdentifierInGUID: true | ||
| conditions: | ||
| - attribute: newrelic.entity.type | ||
| value: DPO | ||
| - attribute: eventTime | ||
| present: true | ||
| - attribute: updatedAt | ||
| present: false | ||
| - attribute: producer | ||
| present: true | ||
| - attribute: schemaURL | ||
| present: true | ||
| - attribute: dataset.namespace | ||
| present: true | ||
| - attribute: dataset.name | ||
| present: true | ||
| tags: | ||
| dataset.namespace: | ||
| entityTagName: olin.dataset.namespace | ||
| multiValue: false | ||
| dataset.name: | ||
| entityTagName: olin.dataset.name | ||
| multiValue: false | ||
| configuration: | ||
| entityExpirationTime: MANUAL | ||
| alertable: true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| [ | ||
| { | ||
| "newrelic.entity.type": "DPO", | ||
| "eventTime": "2019-08-24T14:15:22Z", | ||
| "producer": "https://github.com/OpenLineage/OpenLineage/blob/v1-0-0/client", | ||
| "schemaURL": "https://openlineage.io/spec/0-0-1/OpenLineage.json", | ||
| "dataset.namespace": "my-datasource-namespace", | ||
| "dataset.name": "instance.schema.table" | ||
| } | ||
| ] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| domain: DPO | ||
| type: OLIN_JOB_VERSIONS | ||
| synthesis: | ||
| rules: | ||
| - compositeIdentifier: | ||
| separator: ":" | ||
| attributes: | ||
| - job.namespace | ||
| - job.name | ||
| - updatedAt | ||
| name: job.name | ||
| encodeIdentifierInGUID: true | ||
| conditions: | ||
| - attribute: newrelic.entity.type | ||
| value: DPO | ||
| - attribute: eventTime | ||
| present: true | ||
| - attribute: updatedAt | ||
| present: true | ||
| - attribute: producer | ||
| present: true | ||
| - attribute: schemaURL | ||
| present: true | ||
| - attribute: job.namespace | ||
| present: true | ||
| - attribute: job.name | ||
| present: true | ||
| tags: | ||
| job.namespace: | ||
| entityTagName: olin.job.namespace | ||
| multiValue: false | ||
| job.name: | ||
| entityTagName: olin.job.name | ||
| multiValue: false | ||
| job.updatedAt: | ||
| entityTagName: olin.job.updatedAt | ||
| multiValue: false | ||
| pipeline.name: | ||
| entityTagName: olin.pipeline.name | ||
| multiValue: false | ||
| configuration: | ||
| entityExpirationTime: MANUAL | ||
| alertable: true | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| [ | ||
| { | ||
| "newrelic.entity.type": "DPO", | ||
| "eventTime": "2019-08-24T14:15:22Z", | ||
| "producer": "https://github.com/OpenLineage/OpenLineage/blob/v1-0-0/client", | ||
| "schemaURL": "https://openlineage.io/spec/0-0-1/OpenLineage.json", | ||
| "job.namespace": "my-datasource-namespace", | ||
| "job.name": "myjob.mytask" | ||
| } | ||
| ] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| domain: DPO | ||
| type: OLIN_JOBS | ||
| synthesis: | ||
| rules: | ||
| - compositeIdentifier: | ||
| separator: ":" | ||
| attributes: | ||
| - job.namespace | ||
| - job.name | ||
| - eventTime | ||
| name: job.name | ||
| encodeIdentifierInGUID: true | ||
| conditions: | ||
| - attribute: newrelic.entity.type | ||
| value: DPO | ||
| - attribute: eventTime | ||
| present: true | ||
| - attribute: updatedAt | ||
| present: false | ||
| - attribute: producer | ||
| present: true | ||
| - attribute: schemaURL | ||
| present: true | ||
| - attribute: job.namespace | ||
| present: true | ||
| - attribute: job.name | ||
| present: true | ||
| tags: | ||
| job.namespace: | ||
| entityTagName: olin.job.namespace | ||
| multiValue: false | ||
| job.name: | ||
| entityTagName: olin.job.name | ||
| multiValue: false | ||
| pipeline.name: | ||
| entityTagName: olin.pipeline.name | ||
| multiValue: false | ||
| configuration: | ||
| entityExpirationTime: MANUAL | ||
| alertable: true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| [ | ||
| { | ||
| "newrelic.entity.type": "DPO", | ||
| "eventTime": "2019-08-24T14:15:22Z", | ||
| "updatedAt": "2019-08-24T14:15:22Z", | ||
| "producer": "https://github.com/OpenLineage/OpenLineage/blob/v1-0-0/client", | ||
| "schemaURL": "https://openlineage.io/spec/0-0-1/OpenLineage.json", | ||
| "job.namespace": "my-datasource-namespace", | ||
| "job.name": "myjob.mytask" | ||
| } | ||
| ] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| domain: DPO | ||
| type: OLIN_PIPELINES | ||
| synthesis: | ||
| rules: | ||
| - compositeIdentifier: | ||
| separator: ":" | ||
| attributes: | ||
| - pipeline.namespace | ||
| - pipeline.name | ||
| name: pipeline.name | ||
| encodeIdentifierInGUID: true | ||
| conditions: | ||
| - attribute: newrelic.entity.type | ||
| value: DPO | ||
| - attribute: pipeline.name | ||
| present: true | ||
| - attribute: pipeline.namespace | ||
| present: true | ||
| tags: | ||
| pipeline.namespace: | ||
| entityTagName: olin.pipeline.namespace | ||
| multiValue: false | ||
| pipeline.name: | ||
| entityTagName: olin.pipeline.name | ||
| multiValue: false | ||
| configuration: | ||
| entityExpirationTime: MANUAL | ||
| alertable: true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| [ | ||
| { | ||
| "newrelic.entity.type": "DPO", | ||
| "eventTime": "2019-08-24T14:15:22Z", | ||
| "pipeline.namespace": "my-datasource-namespace", | ||
| "pipeline.name": "pipeline.instance1" | ||
| } | ||
| ] |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the conditions for this definition are the same ones than for OLIN_JOBS. The conditions should have some differentiation to avoid collisions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added following condition to differentiate between events since the
updatedAtfield should be present only inOLIN_JOB_VERSIONS. Is this sufficient?I have written similar conditions for
OLIN_DATASETSvsOLIN_DATASET_VERSIONS