Skip to content

fix(gcp): correct NRQL aggregators, scaling, and gcpSample alignment across 36 entity types#3038

Open
sparsi17 wants to merge 5 commits into
newrelic:mainfrom
sparsi17:fix/gcp-golden-metrics-validator-findings
Open

fix(gcp): correct NRQL aggregators, scaling, and gcpSample alignment across 36 entity types#3038
sparsi17 wants to merge 5 commits into
newrelic:mainfrom
sparsi17:fix/gcp-golden-metrics-validator-findings

Conversation

@sparsi17

@sparsi17 sparsi17 commented Jul 10, 2026 •
edited by atlassian Bot
Loading

Copy link
Copy Markdown
Contributor

Summary

Fixes golden-metric NRQL bugs across 36 infra-gcp* entity types, surfaced by running the internal gcp-metric-pr-validator skill. Only the queries.gcp and queries.gcpSample blocks are touched — entity synthesis, tags, and relationships are unchanged.

Ticket: NR-567584

What's fixed

1. Age metrics — latest() → max() (2 golden metrics)

_age gauges should use max(); latest() hides tail lag which is what these charts exist to expose.

  • infra-gcppubsubsnapshot: oldestMessageAge
  • infra-gcppubsubsubscription: oldestUnackedMessageAge

2. PERCENTAGE unit needs * 100 (3 golden metrics)

Source metric is a 0–1 fraction; without * 100, the UI displays 0.02 instead of 2%.

  • infra-gcpaiplatformendpoint: cpuUtilization
  • infra-gcpalloydbinstance: cpuAverageUtilization
  • infra-gcpspannerinstance: cpuUtilization

3. gcp aggregator inconsistent with gcpSample — 1 golden metric

  • infra-gcppubsubtopic: sendMessageRequests — aligned to rate(sum(...), 1 minute) / 60

4. DISTRIBUTION metrics: average() → percentile(..., 95) (11 metrics across 9 entity types)

average() on a DELTA/DISTRIBUTION is statistically unreliable for latency; p95 surfaces tail behaviour.
Entities: GCPAIPLATFORMENDPOINT, GCPAIPLATFORMFEATURESTORE, GCPAIPLATFORMFEATUREONLINESTORE, GCPAIPLATFORMINDEX, GCPAPPENGINESERVICE, GCPBIGTABLETABLE, GCPBIGQUERYPROJECT, GCPEXTERNALLOADBALANCER, GCPINTERNALLOADBALANCER, GCPINTERNALHTTPLOADBALANCER, GCPHTTPEXTERNALREGIONALLOADBALANCER, GCPHTTPLOADBALANCER

5. GAUGE sum() → average() / latest() (12 metrics)

Summing a GAUGE over time windows inflates values by the number of data points.

  • latest() for byte-level storage gauges (BigQuery storedBytes, AlloyDB cluster storage)
  • average() for count gauges (BigQuery table count, query count, AlloyDB connections, etc.)

6. DELTA count average() → sum() / rate() (9 metrics)

average() on a DELTA counter returns per-bucket mean, not the event total.

  • sum() for error/request counts (BigTable server metrics, Endpoint network bytes, Index datapoints)
  • rate(sum(...), 1 second) for per-second byte rates (HOST GCE network Tx/Rx)
  • rate(sum(...), 1 minute) for CUMULATIVE counters (Composer workload restart count)

7. 0–1 fraction * 100 scaling (9 metrics)

CPU load and utilisation metrics reported as 0–1 fractions but declared unit: PERCENTAGE.
Entities: GCPAIPLATFORMFEATURESTORE, GCPAIPLATFORMFEATUREONLINESTORE, GCPALLOYDBINSTANCE, GCPALLOYDBINSTANCENODE, GCPBIGTABLECLUSTER

8. BigTable cluster metric names camelCase → snake_case (4 metrics)

gcp.bigtable.cluster.cpuLoad → gcp.bigtable.cluster.cpu_load, etc.

9. Load balancer latencies: drop erroneous /1000 (6 metrics, unit=MS)

average(metric)/1000 converted ms → seconds but unit: MS was declared; values were 1000× too small.
Entities: GCPHTTPLOADBALANCER, GCPHTTPEXTERNALREGIONALLOADBALANCER, GCPINTERNALHTTPLOADBALANCER

10. AlloyDB backup timestamp: /1000000 → /1000 (microseconds → milliseconds)

11. ManagedKafka cpuWorkerCoreUsageTime: rate per minute → per second; unit PERCENTAGE → COUNT

12. gcpSample alignment

All gcpSample: query blocks updated to use the same aggregation function as their paired gcp: block to satisfy the entity-definitions validator rule.

Files changed

36 golden_metrics.yml files across the infra-gcp* entity types.

ARB
NR-567584

Test plan

  • Entity-definitions CI validators pass
  • Latency golden metrics show p95 values (not averages)
  • CPU/load percentage widgets show 0–100 range
  • Storage byte gauges show correct GB/TB values (not inflated sums)
  • HOST GCE network metrics show bytes/s

🤖 Generated with Claude Code

entityBot
entityBot previously requested changes Jul 10, 2026
View reviewed changes

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

  • No valid, approved ARB ticket found in the PR description. This PR has to be reviewed by the API Review Board, please include a link to the ticket of that review in the PR description. Check how to start the process here or reach #api-review-board channel in case of doubts

@entityBot entityBot requested a review from a team July 10, 2026 11:14
@entityBot entityBot dismissed their stale review July 10, 2026 12:41

Let's validate those changes.

entityBot
entityBot previously requested changes Jul 10, 2026
View reviewed changes

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

  • No valid, approved ARB ticket found in the PR description. This PR has to be reviewed by the API Review Board, please include a link to the ticket of that review in the PR description. Check how to start the process here or reach #api-review-board channel in case of doubts

@sparsi17 sparsi17 changed the title fix(gcp): correct golden-metric prefixes, aggregators, and scaling in 9 entity types fix(gcp): correct golden-metric prefixes, aggregators, and scaling in 10 entity types Jul 10, 2026
@entityBot entityBot dismissed their stale review July 10, 2026 12:43

Let's validate those changes.

entityBot
entityBot previously requested changes Jul 10, 2026
View reviewed changes

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

  • No valid, approved ARB ticket found in the PR description. This PR has to be reviewed by the API Review Board, please include a link to the ticket of that review in the PR description. Check how to start the process here or reach #api-review-board channel in case of doubts

cnivyanthsai
cnivyanthsai previously approved these changes Jul 10, 2026
View reviewed changes
@entityBot entityBot requested a review from a team July 10, 2026 13:25
cnivyanthsai
cnivyanthsai previously approved these changes Jul 10, 2026
View reviewed changes
@sparsi17

sparsi17 commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

Let's validate those changes.

@sparsi17

sparsi17 commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

gc publish

@sparsi17 sparsi17 requested a review from entityBot July 13, 2026 01:55
entityBot
entityBot previously approved these changes Jul 13, 2026
View reviewed changes
@entityBot entityBot requested review from a team and removed request for a team July 13, 2026 01:55
@entityBot entityBot dismissed stale reviews from cnivyanthsai and cnivyanthsai July 13, 2026 07:47

Dismissing reviews

entityBot
entityBot previously approved these changes Jul 13, 2026
View reviewed changes
cnivyanthsai
cnivyanthsai previously approved these changes Jul 13, 2026
View reviewed changes
@entityBot entityBot requested a review from a team July 13, 2026 08:52
@entityBot entityBot dismissed cnivyanthsai’s stale review July 14, 2026 07:31

Dismissing reviews

entityBot
entityBot previously approved these changes Jul 14, 2026
View reviewed changes
@entityBot entityBot requested review from a team and removed request for a team July 14, 2026 07:32
@entityBot entityBot dismissed stale reviews from themself July 14, 2026 09:47

Let's validate those changes.

entityBot
entityBot previously requested changes Jul 14, 2026
View reviewed changes

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

  • Error VALIDATING domainType: 'INFRA-GCPINTERNALLOADBALANCER' on Golden metrics for key 'SELECT average(l3.internal.RttLatencies) / 1000 FROM GcpInternalLoadBalancerSample WHERE entityGuid IN ('guid') FACET entityName TIMESERIES' - Exception: The select clause uses a different value function than the rest.
  • Error VALIDATING domainType: 'INFRA-GCPINTERNALHTTPLOADBALANCER' on Golden metrics for key 'SELECT average(https.internal.BackendLatencies) / 1000 FROM GcpInternalHttpLoadBalancerSample WHERE entityGuid IN ('guid') FACET entityName TIMESERIES' - Exception: The select clause uses a different value function than the rest.
  • Error VALIDATING domainType: 'INFRA-GCPINTERNALHTTPLOADBALANCER' on Golden metrics for key 'SELECT average(https.internal.TotalLatencies) / 1000 FROM GcpInternalHttpLoadBalancerSample WHERE entityGuid IN ('guid') FACET entityName TIMESERIES' - Exception: The select clause uses a different value function than the rest.
  • Error VALIDATING domainType: 'INFRA-GCPAIPLATFORMENDPOINT' on Golden metrics for key 'SELECT average(prediction.online.network.SentBytes) FROM GcpVertexAiEndpointSample WHERE entityGuid IN ('guid') FACET entityName TIMESERIES' - Exception: The select clause uses a different value function than the rest.
  • Error VALIDATING domainType: 'INFRA-GCPAIPLATFORMENDPOINT' on Golden metrics for key 'SELECT average(prediction.online.network.ReceivedBytes) FROM GcpVertexAiEndpointSample WHERE entityGuid IN ('guid') FACET entityName TIMESERIES' - Exception: The select clause uses a different value function than the rest.
  • Error VALIDATING domainType: 'INFRA-GCPAPPENGINESERVICE' on Golden metrics for key 'SELECT average(server.ResponseLatenciesMilliseconds) / 1000 FROM GcpAppEngineServiceSample WHERE entityGuid IN ('guid') FACET entityName TIMESERIES' - Exception: The select clause uses a different value function than the rest.
  • Error VALIDATING domainType: 'INFRA-GCPBIGQUERYDATASET' on Golden metrics for key 'SELECT sum(storage.StoredBytes) FROM GcpBigQueryDataSetSample WHERE entityGuid IN ('guid') FACET entityName TIMESERIES' - Exception: The select clause uses a different value function than the rest.
  • Error VALIDATING domainType: 'INFRA-GCPBIGQUERYDATASET' on Golden metrics for key 'SELECT sum(storage.Tables) FROM GcpBigQueryDataSetSample WHERE entityGuid IN ('guid') FACET entityName TIMESERIES' - Exception: The select clause uses a different value function than the rest.
  • Error VALIDATING domainType: 'INFRA-GCPAIPLATFORMFEATURESTORE' on Golden metrics for key 'SELECT average(featurestore.online_serving.Latencies) FROM GcpVertexAiFeaturestoreSample WHERE entityGuid IN ('guid') FACET entityName TIMESERIES' - Exception: The select clause uses a different value function than the rest.
  • Error VALIDATING domainType: 'INFRA-GCPEXTERNALLOADBALANCER' on Golden metrics for key 'SELECT average(l3.external.RttLatencies) / 1000 FROM GcpExternalLoadBalancerSample WHERE entityGuid IN ('guid') FACET entityName TIMESERIES' - Exception: The select clause uses a different value function than the rest.
  • Error VALIDATING domainType: 'INFRA-GCPHTTPEXTERNALREGIONALLOADBALANCER' on Golden metrics for key 'SELECT average(https.external.regional.BackendLatencies) / 1000 FROM GcpHttpExternalRegionalLoadBalancerSample WHERE entityGuid IN ('guid') FACET entityName TIMESERIES' - Exception: The select clause uses a different value function than the rest.
  • Error VALIDATING domainType: 'INFRA-GCPHTTPEXTERNALREGIONALLOADBALANCER' on Golden metrics for key 'SELECT average(https.external.regional.TotalLatencies) / 1000 FROM GcpHttpExternalRegionalLoadBalancerSample WHERE entityGuid IN ('guid') FACET entityName TIMESERIES' - Exception: The select clause uses a different value function than the rest.
  • Error VALIDATING domainType: 'INFRA-GCPAIPLATFORMLOCATION' on Golden metrics for key 'SELECT average(gcp.aiplatform.executing_vertexai_pipeline_tasks) FROM Metric WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - Exception: The select clause uses a different value function than the rest.
  • Error VALIDATING domainType: 'INFRA-GCPAIPLATFORMLOCATION' on Golden metrics for key 'SELECT sum(gcp.aiplatform.online_prediction_requests_per_base_model) FROM Metric WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - Exception: The select clause uses a different value function than the rest.
  • Error VALIDATING domainType: 'INFRA-GCPAIPLATFORMFEATUREONLINESTORE' on Golden metrics for key 'SELECT percentile(gcp.aiplatform.featureonlinestore.online_serving.serving_latencies, 95) FROM Metric WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - Exception: The select clause uses a different value function than the rest.
  • Error VALIDATING domainType: 'INFRA-GCPBIGQUERYPROJECT' on Golden metrics for key 'SELECT sum(query.Count) FROM GcpBigQueryProjectSample WHERE entityGuid IN ('guid') FACET entityName TIMESERIES' - Exception: The select clause uses a different value function than the rest.
  • Error VALIDATING domainType: 'INFRA-GCPBIGQUERYPROJECT' on Golden metrics for key 'SELECT average(query.ExecutionTimes) FROM GcpBigQueryProjectSample WHERE entityGuid IN ('guid') FACET entityName TIMESERIES' - Exception: The select clause uses a different value function than the rest.
  • Error VALIDATING domainType: 'INFRA-HOST' on Golden metrics for key 'SELECT rate(sum(gcp.compute.instance.network.sent_bytes_count), 1 second) FROM Metric WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - Exception: The select clause uses a different value function than the rest.
  • Error VALIDATING domainType: 'INFRA-HOST' on Golden metrics for key 'SELECT rate(sum(gcp.compute.instance.network.received_bytes_count), 1 second) FROM Metric WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - Exception: The select clause uses a different value function than the rest.
  • Error VALIDATING domainType: 'INFRA-GCPAIPLATFORMINDEX' on Golden metrics for key 'SELECT average(matchingEngine.streamUpdate.Latencies) FROM GcpVertexAiIndexSample WHERE entityGuid IN ('guid') FACET entityName TIMESERIES' - Exception: The select clause uses a different value function than the rest.
  • Error VALIDATING domainType: 'INFRA-GCPAIPLATFORMINDEX' on Golden metrics for key 'SELECT average(matchingEngine.streamUpdate.Datapoint) FROM GcpVertexAiIndexSample WHERE entityGuid IN ('guid') FACET entityName TIMESERIES' - Exception: The select clause uses a different value function than the rest.
  • Error VALIDATING domainType: 'INFRA-GCPBIGTABLETABLE' on Golden metrics for key 'SELECT average(replication.Latency) FROM GcpBigtableTableSample WHERE entityGuid IN ('guid') FACET entityName TIMESERIES' - Exception: The select clause uses a different value function than the rest.
  • Error VALIDATING domainType: 'INFRA-GCPBIGTABLETABLE' on Golden metrics for key 'SELECT average(server.Error) FROM GcpBigtableTableSample WHERE entityGuid IN ('guid') FACET entityName TIMESERIES' - Exception: The select clause uses a different value function than the rest.
  • Error VALIDATING domainType: 'INFRA-GCPBIGTABLETABLE' on Golden metrics for key 'SELECT average(server.Request) FROM GcpBigtableTableSample WHERE entityGuid IN ('guid') FACET entityName TIMESERIES' - Exception: The select clause uses a different value function than the rest.
  • Error VALIDATING domainType: 'INFRA-GCPBIGTABLETABLE' on Golden metrics for key 'SELECT average(server.SentBytes) FROM GcpBigtableTableSample WHERE entityGuid IN ('guid') FACET entityName TIMESERIES' - Exception: The select clause uses a different value function than the rest.
  • Error VALIDATING domainType: 'INFRA-GCPHTTPLOADBALANCER' on Golden metrics for key 'SELECT average(https.BackendLatencies) / 1000 FROM GcpHttpLoadBalancerSample WHERE entityGuid IN ('guid') FACET entityName TIMESERIES' - Exception: The select clause uses a different value function than the rest.
  • Error VALIDATING domainType: 'INFRA-GCPHTTPLOADBALANCER' on Golden metrics for key 'SELECT average(https.TotalLatencies) / 1000 FROM GcpHttpLoadBalancerSample WHERE entityGuid IN ('guid') FACET entityName TIMESERIES' - Exception: The select clause uses a different value function than the rest.

@entityBot entityBot requested review from a team July 14, 2026 09:48
@entityBot entityBot dismissed their stale review July 14, 2026 10:47

Let's validate those changes.

entityBot
entityBot previously requested changes Jul 14, 2026
View reviewed changes

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

  • Error VALIDATING domainType: 'INFRA-HOST' on Golden metrics for key 'SELECT rate(sum(instance.network.SentBytes), 1 second) FROM GcpVirtualMachineSample WHERE entityGuid IN ('guid') FACET entityName TIMESERIES' - Exception: The select clause uses a different value function than the rest.
  • Error VALIDATING domainType: 'INFRA-HOST' on Golden metrics for key 'SELECT rate(sum(gcp.compute.instance.network.sent_bytes_count), 1 second) FROM Metric WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - Exception: The select clause uses a different value function than the rest.
  • Error VALIDATING domainType: 'INFRA-HOST' on Golden metrics for key 'SELECT rate(sum(instance.network.ReceivedBytes), 1 second) FROM GcpVirtualMachineSample WHERE entityGuid IN ('guid') FACET entityName TIMESERIES' - Exception: The select clause uses a different value function than the rest.
  • Error VALIDATING domainType: 'INFRA-HOST' on Golden metrics for key 'SELECT rate(sum(gcp.compute.instance.network.received_bytes_count), 1 second) FROM Metric WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - Exception: The select clause uses a different value function than the rest.

sparsi17 and others added 3 commits July 14, 2026 16:34
@sparsi17 @claude
fix(gcp): correct golden-metric aggregators and scaling
94e35d8 
Age metrics -> max() (pubsub snapshot/subscription oldestMessageAge).
PERCENTAGE unit *100 (endpoint cpuUtilization, alloydb cpuAverageUtilization,
spanner cpuUtilization — 0-1 fractions without *100 render as 0.02 not 2%).
pubsubtopic sendMessageRequests: aligned gcp block to rate(sum,1min)/60
to match gcpSample.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@sparsi17 @claude
fix(gcp): correct aggregators, scaling, and metric names across 21 en…
2a2daef 
…tity types

- DISTRIBUTION metrics: average() → percentile(..., 95) (serving_latencies,
  prediction_latencies, stream_update.latencies, online_serving.latencies,
  replication.latency, server.latencies, execution_times, response_latencies,
  rtt_latencies, backend_latencies, total_latencies)
- GAUGE 0-1 fractions shown as PERCENTAGE: append *100 (cpu.utilization,
  featurestore.cpu_load, cpu_load/hottest_node, bigtable_cpu_load,
  cpu.average_utilization, cpu.maximum_utilization, cpu.usage_time,
  bigtable cluster disk_load/storage_utilization/cpu metrics)
- GAUGE sum() → average()/latest(): stored_bytes, storage.usage,
  query.count, table_count, executing_pipeline_jobs/tasks, bigtable_nodes,
  total_connections, postgres.backends, network.attachment
- DELTA average() → sum()/rate(): network counts, server request counts,
  online_prediction_requests, datapoint_count
- BigTable cluster camelCase → snake_case metric names
- Load balancer latencies: drop /1000 (already ms, unit=MS); l3 keep /1000 (unit=SECONDS)
- ManagedKafka cpuWorkerCoreUsageTime: rate per minute → per second; unit PERCENTAGE → COUNT
- HOST GCE network: average() → rate(sum(), 1 second) for BYTES_PER_SECOND metrics
- Composer workload restartCount: sum() → rate(sum(), 1 minute) for CUMULATIVE counter

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@sparsi17 @claude
fix(gcp): align gcpSample aggregation functions with gcp queries to p…
ce0ce5f 
…ass validation

Validator requires all queries within a golden metric entry to use the same
value function. Updates gcpSample: select clauses to match the gcp: changes:

- Latency DISTRIBUTION metrics: average → percentile(..., 95)
  (BackendLatencies, TotalLatencies, RttLatencies, ServingLatencies,
   ResponseLatenciesMilliseconds, online_serving.Latencies, replication.Latency,
   streamUpdate.Latencies)
- DELTA count metrics: average → sum
  (SentBytes/ReceivedBytes network counts, server.Error/Request/SentBytes,
   streamUpdate.Datapoint)
- GAUGE byte-level: sum → latest (storage.StoredBytes)
- GAUGE count: sum → average (storage.Tables, query.Count)
- GAUGE per-second: average → rate(sum(...), 1 second) (instance.network bytes)
- DELTA count with percentile: average → percentile (query.ExecutionTimes)
- LOCATION pipeline tasks: sum → average; prediction requests: average → sum
- HTTP LB latencies (unit=MS): remove /1000 from gcpSample (was wrong unit conversion)

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@sparsi17 sparsi17 force-pushed the fix/gcp-golden-metrics-validator-findings branch from 2d7c8e4 to ce0ce5f Compare July 14, 2026 11:04
@entityBot entityBot dismissed their stale review July 14, 2026 11:05

Let's validate those changes.

entityBot
entityBot previously requested changes Jul 14, 2026
View reviewed changes

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

  • Error VALIDATING domainType: 'INFRA-HOST' on Golden metrics for key 'SELECT rate(sum(instance.network.SentBytes), 1 second) FROM GcpVirtualMachineSample WHERE entityGuid IN ('guid') FACET entityName TIMESERIES' - Exception: The select clause uses a different value function than the rest.
  • Error VALIDATING domainType: 'INFRA-HOST' on Golden metrics for key 'SELECT rate(sum(gcp.compute.instance.network.sent_bytes_count), 1 second) FROM Metric WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - Exception: The select clause uses a different value function than the rest.
  • Error VALIDATING domainType: 'INFRA-HOST' on Golden metrics for key 'SELECT rate(sum(instance.network.ReceivedBytes), 1 second) FROM GcpVirtualMachineSample WHERE entityGuid IN ('guid') FACET entityName TIMESERIES' - Exception: The select clause uses a different value function than the rest.
  • Error VALIDATING domainType: 'INFRA-HOST' on Golden metrics for key 'SELECT rate(sum(gcp.compute.instance.network.received_bytes_count), 1 second) FROM Metric WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - Exception: The select clause uses a different value function than the rest.

@sparsi17 sparsi17 changed the title fix(gcp): correct golden-metric prefixes, aggregators, and scaling in 10 entity types fix(gcp): correct NRQL aggregators, scaling, and gcpSample alignment across 36 entity types Jul 14, 2026
@sparsi17 @claude
fix(gcp): update golden metric titles to reflect p95 aggregation
139e87d 
Metrics changed from average() to percentile(..., 95) now carry 'p95'
and explicit unit in their title so the UI label matches the query.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@entityBot entityBot dismissed their stale review July 14, 2026 11:39

Let's validate those changes.

entityBot
entityBot previously requested changes Jul 14, 2026
View reviewed changes

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

  • Error VALIDATING domainType: 'INFRA-HOST' on Golden metrics for key 'SELECT rate(sum(instance.network.SentBytes), 1 second) FROM GcpVirtualMachineSample WHERE entityGuid IN ('guid') FACET entityName TIMESERIES' - Exception: The select clause uses a different value function than the rest.
  • Error VALIDATING domainType: 'INFRA-HOST' on Golden metrics for key 'SELECT rate(sum(gcp.compute.instance.network.sent_bytes_count), 1 second) FROM Metric WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - Exception: The select clause uses a different value function than the rest.
  • Error VALIDATING domainType: 'INFRA-HOST' on Golden metrics for key 'SELECT rate(sum(instance.network.ReceivedBytes), 1 second) FROM GcpVirtualMachineSample WHERE entityGuid IN ('guid') FACET entityName TIMESERIES' - Exception: The select clause uses a different value function than the rest.
  • Error VALIDATING domainType: 'INFRA-HOST' on Golden metrics for key 'SELECT rate(sum(gcp.compute.instance.network.received_bytes_count), 1 second) FROM Metric WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - Exception: The select clause uses a different value function than the rest.

@entityBot entityBot dismissed their stale review July 14, 2026 11:53

Let's validate those changes.

entityBot
entityBot previously requested changes Jul 14, 2026
View reviewed changes

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

  • Error VALIDATING domainType: 'INFRA-HOST' on Golden metrics for key 'SELECT rate(sum(instance.network.SentBytes), 1 second) FROM GcpVirtualMachineSample WHERE entityGuid IN ('guid') FACET entityName TIMESERIES' - Exception: The select clause uses a different value function than the rest.
  • Error VALIDATING domainType: 'INFRA-HOST' on Golden metrics for key 'SELECT rate(sum(gcp.compute.instance.network.sent_bytes_count), 1 second) FROM Metric WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - Exception: The select clause uses a different value function than the rest.
  • Error VALIDATING domainType: 'INFRA-HOST' on Golden metrics for key 'SELECT rate(sum(instance.network.ReceivedBytes), 1 second) FROM GcpVirtualMachineSample WHERE entityGuid IN ('guid') FACET entityName TIMESERIES' - Exception: The select clause uses a different value function than the rest.
  • Error VALIDATING domainType: 'INFRA-HOST' on Golden metrics for key 'SELECT rate(sum(gcp.compute.instance.network.received_bytes_count), 1 second) FROM Metric WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - Exception: The select clause uses a different value function than the rest.

abhavanam-blip
abhavanam-blip approved these changes Jul 14, 2026
View reviewed changes

@abhavanam-blip abhavanam-blip left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sparsi17

sparsi17 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

gc publish

1 similar comment
@sparsi17

sparsi17 commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

gc publish

@sparsi17 sparsi17 requested a review from entityBot July 15, 2026 06:31
@entityBot entityBot dismissed their stale review July 15, 2026 06:31

Let's validate those changes.

entityBot
entityBot requested changes Jul 15, 2026
View reviewed changes

@entityBot entityBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

  • Error VALIDATING domainType: 'INFRA-HOST' on Golden metrics for key 'SELECT rate(sum(instance.network.SentBytes), 1 second) FROM GcpVirtualMachineSample WHERE entityGuid IN ('guid') FACET entityName TIMESERIES' - Exception: The select clause uses a different value function than the rest.
  • Error VALIDATING domainType: 'INFRA-HOST' on Golden metrics for key 'SELECT rate(sum(gcp.compute.instance.network.sent_bytes_count), 1 second) FROM Metric WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - Exception: The select clause uses a different value function than the rest.
  • Error VALIDATING domainType: 'INFRA-HOST' on Golden metrics for key 'SELECT rate(sum(instance.network.ReceivedBytes), 1 second) FROM GcpVirtualMachineSample WHERE entityGuid IN ('guid') FACET entityName TIMESERIES' - Exception: The select clause uses a different value function than the rest.
  • Error VALIDATING domainType: 'INFRA-HOST' on Golden metrics for key 'SELECT rate(sum(gcp.compute.instance.network.received_bytes_count), 1 second) FROM Metric WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - Exception: The select clause uses a different value function than the rest.

@entityBot entityBot requested a review from a team July 15, 2026 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@entityBot entityBot entityBot requested changes
+2 more reviewers
@abhavanam-blip abhavanam-blip abhavanam-blip approved these changes
@cnivyanthsai cnivyanthsai cnivyanthsai approved these changes
Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

ARB:approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sparsi17 @entityBot @abhavanam-blip @cnivyanthsai