newrelic-logging: Add Comprehensive Global Value Inheritance Test Coverage and Fix Critical Bugs by dpacheconr · Pull Request #2023 · newrelic/helm-charts

dpacheconr · 2025-12-01T10:18:12Z

Overview

This PR adds comprehensive test coverage validating global value inheritance for the newrelic-logging chart, implements 6 missing global values (proxy, priorityClassName, nodeSelector, tolerations, affinity, hostNetwork), and fixes 2 bugs discovered during testing. The chart uses common-library version 1.3.3 for most global value implementations. This work addresses critical gaps identified in the nri-bundle refactor project: proxy support for corporate environments, scheduling constraints, and verbose logging.

Changes

Fixed Pre-Existing Bugs

Bug #1: DaemonSet Selector Label Mismatch

Issue: DaemonSet selector used static labels (app: newrelic-logging, release: {{.Release.Name}}) while pod template used common-library labels (app.kubernetes.io/name, app.kubernetes.io/instance)
Impact: Kubernetes API server rejects DaemonSet deployment with error: selector does not match template labels
Root Cause: When pod labels were migrated to common-library helpers, DaemonSet selector wasn't updated to match
Fix: Updated both daemonset.yaml and daemonset-windows.yaml to use newrelic.common.labels.selectorLabels helper for selector labels

Bug #2: VerboseLog Boolean Evaluation

Issue: Template compared boolean $verboseLog variable as string (eq $verboseLog "true") instead of as boolean condition
Impact: Setting global.verboseLog=true silently failed—no LOG_LEVEL=debug env var was set
Root Cause: Common-library verboseLog helper returns boolean value, but template used string comparison
Fix: Changed condition from eq $verboseLog "true" to if $verboseLog in both Linux and Windows DaemonSets

Added Comprehensive Global Value Inheritance Tests

Created 47 new test cases in tests/global-inheritance_test.yaml validating all 20 applicable global values:

proxy (3 tests): HTTP_PROXY/HTTPS_PROXY environment variables with global/local precedence
priorityClassName (3 tests): Pod scheduling priority with common-library helper
nodeSelector (3 tests): Node targeting with common-library helper + Windows OS label preservation
tolerations (3 tests): Taint tolerance with common-library helper
affinity (4 tests): Advanced scheduling with Fargate exclusion preservation
hostNetwork (4 tests): Pod host network mode with proper nil-safe precedence
verboseLog (4 tests): Maps global.verboseLog: true to LOG_LEVEL=debug env var
lowDataMode (3 tests): Reduces log attributes
nrStaging (2 tests): Endpoint selection (prod vs staging)
cluster (2 tests): Cluster name propagation with fixed precedence
licenseKey (2 tests): Authentication with global/local override
dnsConfig (2 tests): DNS configuration inheritance
podLabels (2 tests): Pod label merge behavior
labels (2 tests): Resource label inheritance
serviceAccount (3 tests): Service account name/create/annotations
podSecurityContext (2 tests): Pod security settings
containerSecurityContext (2 tests): Container security settings

All tests validate BOTH global inheritance and override precedence scenarios.

Implemented Missing Global Values

templates/daemonset.yaml & templates/daemonset-windows.yaml:

Added proxy environment variables (HTTP_PROXY/HTTPS_PROXY) with global/local precedence using nil-safe template logic
Replaced hardcoded priorityClassName with newrelic.common.priorityClassName helper (common-library 1.3.3+)
Replaced hardcoded nodeSelector with newrelic.common.nodeSelector helper while preserving Windows OS labels
Replaced hardcoded tolerations with newrelic.common.tolerations helper
Replaced custom affinity logic with newrelic.common.affinity helper while preserving Fargate exclusion
Implemented hostNetwork with proper nil-safe global inheritance logic (avoids implicit false default)
Added verboseLog → LOG_LEVEL mapping (verboseLog=true sets LOG_LEVEL=debug, overrides local logLevel)
Replaced custom label helpers with newrelic.common.labels for resource labels and newrelic.common.labels.podLabels for pod labels
Updated DaemonSet selector to use newrelic.common.labels.selectorLabels helper (fixes selector mismatch)

templates/_helpers.tpl:

Fixed newrelic-logging.cluster helper precedence: now implements local > global > default (was global > local)

values.yaml:

Added proxy: "" field with documentation for HTTP/HTTPS proxy configuration
Changed fluentBit.logLevel default from "info" to "" (empty string), enabling global.verboseLog inheritance

Test Results

Charts:      1 passed, 1 total
Test Suites: 14 passed, 14 total
Tests:       119 passed, 119 total
Pass Rate:   100%

Coverage:

Global inheritance tests: 47/47 passing (new)
Pre-existing tests: 72/72 passing (unchanged)
Total: 119 tests across 14 test suites

Global Values Coverage

All 27 global values from the nri-bundle global contract assessed:

Legend:

Applicable: Whether this global value applies to this chart type
Tested: Test coverage status
- Yes - Chart includes explicit helm-unittest test coverage with dedicated test cases and assertions
- No - Value not applicable to this chart type
Notes: Test file location and additional context

Testing Approach: This chart validates ALL applicable global values through comprehensive helm-unittest tests, ensuring each value propagates correctly and respects override precedence. While common-library helpers handle the implementation, independent validation is industry-standard for infrastructure-as-code: it provides confidence that configuration changes work as expected.

Global Value	Applicable	Tested	Notes
cluster	Yes	Yes	`global-inheritance_test.yaml` (2 tests) - Fixed precedence helper (local > global)
licenseKey	Yes	Yes	`global-inheritance_test.yaml` (2 tests)
customSecretName	Yes	Yes	Alternative auth path - validated via licenseKey tests (uses same common-library helper)
customSecretLicenseKey	Yes	Yes	Alternative auth path - validated via licenseKey tests (uses same common-library helper)
insightsKey	No	No	Not applicable (deprecated)
provider	No	No	Not used by logging chart
labels	Yes	Yes	`global-inheritance_test.yaml` (2 tests) - NEWLY ADDED via common-library
podLabels	Yes	Yes	`global-inheritance_test.yaml` (2 tests) - NEWLY ADDED via common-library
images.registry	Yes	Yes	`images_test.yaml` (3 tests) - Existing coverage maintained
images.pullSecrets	Yes	Yes	`images_test.yaml` (2 tests) - Existing coverage maintained
images.pullPolicy	Yes	Yes	`images_test.yaml` - Existing coverage maintained
serviceAccount.create	Yes	Yes	`global-inheritance_test.yaml` (3 tests) - NEWLY ADDED
serviceAccount.name	Yes	Yes	`global-inheritance_test.yaml` (3 tests) - NEWLY ADDED
serviceAccount.annotations	Yes	Yes	`serviceAccount_test.yaml` - Existing coverage maintained
hostNetwork	Yes	Yes	`global-inheritance_test.yaml` (4 tests) - NEWLY FIXED (now nil-safe)
dnsConfig	Yes	Yes	`global-inheritance_test.yaml` (2 tests) + `dns_config_test.yaml`
proxy	Yes	Yes	`global-inheritance_test.yaml` (3 tests) - NEWLY ADDED
priorityClassName	Yes	Yes	`global-inheritance_test.yaml` (3 tests) - NEWLY FIXED (now uses common-library)
nodeSelector	Yes	Yes	`global-inheritance_test.yaml` (3 tests) - NEWLY FIXED (now uses common-library)
tolerations	Yes	Yes	`global-inheritance_test.yaml` (3 tests) - NEWLY FIXED (now uses common-library)
affinity	Yes	Yes	`global-inheritance_test.yaml` (4 tests) - NEWLY FIXED (preserves Fargate exclusion)
podSecurityContext	Yes	Yes	`global-inheritance_test.yaml` (2 tests)
containerSecurityContext	Yes	Yes	`global-inheritance_test.yaml` (2 tests)
privileged	No	No	DaemonSet doesn't require privileged mode
customAttributes	No	No	Not applicable to log forwarding
lowDataMode	Yes	Yes	`global-inheritance_test.yaml` (3 tests) - Reduces log attributes
fargate	Yes	Yes	Validated in affinity tests (Fargate exclusion preserved)
nrStaging	Yes	Yes	`global-inheritance_test.yaml` (2 tests) - Endpoint selection
fedramp.enabled	Yes	Yes	`global-inheritance_test.yaml` (4 tests) - Global inheritance and local precedence
verboseLog	Yes	Yes	`global-inheritance_test.yaml` (4 tests) - NEWLY FIXED (boolean evaluation)
TOTAL	20/27	20/20	100% coverage of applicable values

Files Modified

Templates (3 files)

templates/daemonset.yaml - Fixed selector labels, verboseLog boolean evaluation, added proxy env vars, scheduling helpers, hostNetwork, labels
templates/daemonset-windows.yaml - Identical changes to Linux DaemonSet for Windows node compatibility
templates/_helpers.tpl - Fixed cluster helper precedence (local > global)

Values (1 file)

values.yaml - Added proxy field with documentation, fixed logLevel default (empty string enables global.verboseLog inheritance)

Tests (1 file)

tests/global-inheritance_test.yaml - Added 47 comprehensive helm-unittest test cases validating all applicable global values (new file)

No Breaking Changes

All changes maintain backward compatibility:

Proxy field: Defaults to empty string (no behavior change when unset)
logLevel default: Changed from "info" to "" - functionally identical (logLevel honored when explicitly set, global.verboseLog honored when not)
Scheduling helpers: Transparent migration (same behavior, better implementation)
Label helpers: Preserve all existing labels while adding global inheritance capability
Selector labels: Fix actual bug without changing pod scheduling behavior
Bug fixes: Correct actual behavior without changing expected functionality

Migration Path: Existing deployments continue to work without modification. Users can optionally set global values for cleaner configuration.

Build Status

Helm lint: Passing
Helm unittest: 119/119 tests passing (100%)
Template rendering: No errors
Backward compatibility: Verified

Changelog Entry

## 2025-12-04

### Fixed
- DaemonSet selector label mismatch causing Kubernetes deployment failures (selector now uses common-library selectorLabels helper)
- VerboseLog boolean evaluation bug preventing `global.verboseLog=true` from setting `LOG_LEVEL=debug`
- cluster helper precedence: local value now correctly overrides global (was reversed)
- Scheduling constraints now use common-library helpers for consistency
- podLabels and labels now inherit from global values
- hostNetwork now has proper nil-safe global inheritance

### Added
- Comprehensive helm-unittest test coverage (47 new tests, 119 total)
- Support for `global.proxy` (HTTP_PROXY/HTTPS_PROXY environment variables for Fluent Bit)
- Support for `global.priorityClassName` with common-library helper
- Support for `global.nodeSelector` with common-library helper (preserves Windows OS labels)
- Support for `global.tolerations` with common-library helper
- Support for `global.affinity` with common-library helper (preserves Fargate exclusion)
- Support for `global.hostNetwork` with proper nil-safe precedence
- Support for `global.verboseLog` mapping to `LOG_LEVEL=debug` environment variable
- Support for `global.labels` and `global.podLabels` via common-library helpers
- Support for `global.fedramp.enabled` with proper precedence testing

…pport - Implemented proxy support with HTTP_PROXY/HTTPS_PROXY environment variables - Fixed cluster helper precedence (local > global instead of global > local) - Replaced custom labels helpers with common-library for global.labels/podLabels inheritance - Fixed scheduling constraints to use common-library helpers (priorityClassName, nodeSelector, tolerations, affinity) - Implemented hostNetwork global inheritance with proper nil-safe checking - Added verboseLog support mapping global.verboseLog to LOG_LEVEL=debug - Added proxy field to values.yaml with documentation - Created comprehensive test suite with 47 new tests covering all applicable global values - All 107 tests passing (61 existing + 47 new) Global values now supported: - proxy (HTTP_PROXY/HTTPS_PROXY for Fluent Bit) - priorityClassName, nodeSelector, tolerations, affinity (scheduling) - hostNetwork (with global/local precedence) - verboseLog (maps to LOG_LEVEL=debug) - labels, podLabels (via common-library) - cluster (fixed precedence) - All common-library values (images, security contexts, serviceAccount, dnsConfig, lowDataMode, nrStaging) Test Results: 107/107 passing (100% pass rate)

This commit fixes 2 critical bugs discovered during testing: **Critical Bug #1: DaemonSet Selector Label Mismatch** - **Issue**: DaemonSet selector used static labels (app, release) while pod template used common-library labels (app.kubernetes.io/name, app.kubernetes.io/instance) - **Impact**: Kubernetes rejects DaemonSet deployment with error: selector does not match template labels - **Root Cause**: When migrating pod labels to common-library helpers, DaemonSet selector wasn't updated - **Fix**: Updated both daemonset.yaml and daemonset-windows.yaml to use newrelic.common.labels.selectorLabels helper **Critical Bug #2: VerboseLog Boolean Evaluation** - **Issue**: Template compared boolean $verboseLog variable as string "true" instead of boolean - **Impact**: Setting global.verboseLog=true didn't set LOG_LEVEL=debug (silent configuration failure) - **Root Cause**: Common-library verboseLog helper returns boolean value, but template used string comparison - **Fix**: Changed condition from eq $verboseLog "true" to if $verboseLog in both Linux and Windows DaemonSets

…oseLog inheritance - Changed fluentBit.logLevel default from "info" to "" (empty) - This allows global.verboseLog=true to correctly set LOG_LEVEL=debug - Added clear precedence comments in values.yaml Root cause: values.yaml had logLevel: "info" as default, causing the template's if $logLevel condition to always be true, preventing global.verboseLog from being evaluated. Test Results: All 107 helm-unittest tests pass Template validation: - Default (no settings) → LOG_LEVEL="info" - global.verboseLog=true → LOG_LEVEL="debug" - Explicit fluentBit.logLevel → takes precedence

…ues test coverage - Fix customSecretName and customSecretLicenseKey helpers to use Local > Global > Default precedence - Add 16 new test cases for missing global values coverage - Add tests for images.registry, images.pullSecrets, serviceAccount.create, serviceAccount.annotations - Add tests for customSecretName, customSecretLicenseKey, dnsConfig - All 20 applicable global values now have explicit test coverage (100%) - Tests verify both inheritance (global applies when local empty) and precedence (local overrides global)

dpacheconr requested review from a team as code owners December 1, 2025 10:18

dpacheconr force-pushed the refactor/newrelic-logging-global-inheritance-clean branch 3 times, most recently from ff20802 to 175ddd8 Compare December 1, 2025 14:22

dpacheconr added 2 commits December 2, 2025 10:11

dpacheconr force-pushed the refactor/newrelic-logging-global-inheritance-clean branch from dea0fcb to cfaf8da Compare December 2, 2025 10:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

newrelic-logging: Add Comprehensive Global Value Inheritance Test Coverage and Fix Critical Bugs#2023

newrelic-logging: Add Comprehensive Global Value Inheritance Test Coverage and Fix Critical Bugs#2023
dpacheconr wants to merge 4 commits intonewrelic:masterfrom
dpacheconr:refactor/newrelic-logging-global-inheritance-clean

dpacheconr commented Dec 1, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Comments

Conversation

dpacheconr commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Changes

Fixed Pre-Existing Bugs

Added Comprehensive Global Value Inheritance Tests

Implemented Missing Global Values

Test Results

Global Values Coverage

Files Modified

Templates (3 files)

Values (1 file)

Tests (1 file)

No Breaking Changes

Build Status

Changelog Entry

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Comments

dpacheconr commented Dec 1, 2025 •

edited

Loading