fix: remove filters dropping critical cpu, memory, and k8s state metrics#2078
Merged
jamescripter merged 7 commits intomasterfrom Feb 4, 2026
Conversation
…dropping-critical-cpu-memory-and-k8s-state-metrics
…dropping-critical-cpu-memory-and-k8s-state-metrics
dbudziwojskiNR
approved these changes
Feb 4, 2026
jamescripter
deleted the
fix/remove-filters-dropping-critical-cpu-memory-and-k8s-state-metrics
branch
3 tasks
jamescripter
added a commit
that referenced
this pull request
Feb 11, 2026
This reverts commit 2d63601. <!-- Thank you for contributing to New Relic's Helm charts. Before you submit this PR we'd like to make sure you are aware of our technical requirements: * https://github.com/newrelic-experimental/helm-charts/blob/master/CONTRIBUTING.md#technical-requirements For a quick overview across what we will look at reviewing your PR, please read our review guidelines: * https://github.com/newrelic-experimental/helm-charts/blob/master/REVIEW_GUIDELINES.md Following our best practices right from the start will accelerate the review process and help get your PR merged quicker. When updates to your PR are requested, please add new commits and do not squash the history. This will make it easier to identify new changes. The PR will be squashed anyways when it is merged. Thanks. For fast feedback, please @-mention maintainers that are listed in the Chart.yaml file. Please make sure you test your changes before you push them. Once pushed, a Github Action will run across your changes and do some initial checks and linting. These checks run very quickly. Please check the results. We would like these checks to pass before we even continue reviewing your changes. --> #### What this PR does / why we need it: Rollback removal of drop rules by [this PR](#2078) until [this concern](https://new-relic.atlassian.net/browse/NR-510732?focusedCommentId=1585631) is resolved by updating some of our dashboard queries to be compatible with the new rules. #### Which issue this PR fixes *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)* - fixes # #### Special notes for your reviewer: #### Checklist [Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.] - [ ] Chart Version bumped - [ ] Variables are documented in the README.md - [ ] Title of the PR starts with chart name (e.g. `[mychartname]`) # Release Notes to Publish (nr-k8s-otel-collector) If this PR contains changes in `nr-k8s-otel-collector`, please complete the following section. All other charts should ignore this section. <!--BEGIN-RELEASE-NOTES--> ## 🚀 What's Changed * Rollback removal of drop rules <!--END-RELEASE-NOTES-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
remove some filters to enable the collection of certain data that is critical for the functionality of certain important dashboards.
Which issue this PR fixes
https://new-relic.atlassian.net/browse/NR-510732?actionerId=712020%3A4f8442e8-7591-4845-bfe0-8f5e6f27b98f&sourceType=assign
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[mychartname])Release Notes to Publish (nr-k8s-otel-collector)
If this PR contains changes in
nr-k8s-otel-collector, please complete the following section. All other charts should ignore this section.🚀 What's Changed