feat: add metadata integration for agent-control-deployment#2179
feat: add metadata integration for agent-control-deployment#2179jcoscollanr wants to merge 3 commits intomasterfrom
Conversation
| if [[ "${{ matrix.chart }}" == "agent-control-deployment" ]]; then | ||
| VERSION=$(yq '.appVersion' charts/${{ matrix.chart }}/Chart.yaml | tr -d '"') | ||
| echo "Extracted version from Chart.yaml appVersion: $VERSION" |
There was a problem hiding this comment.
I think the version we need is not .appVersion (which matches with the agent-control docker image) but .version which identifies this chart's version.
There was a problem hiding this comment.
actually, I did this on purpose.
The main idea is that we want the version to be the same as in the hosts, for the requirements. We can say this works with this version of agent-control
There was a problem hiding this comment.
We have just discussed it offline, this version is not used for self-update but requirements therefore, we do need the appVersion which tells us that the version of the Agent Control binaries is available to be used in K8s. When working on the self-update experience, we will also need the chart-version.
| VERSION="${{ github.event.release.tag_name }}" | ||
| VERSION="${VERSION#${{ matrix.chart }}-}" | ||
| if [[ "${{ matrix.chart }}" == "agent-control-deployment" ]]; then | ||
| VERSION=$(yq '.appVersion' charts/${{ matrix.chart }}/Chart.yaml | tr -d '"') |
There was a problem hiding this comment.
@jcoscollanr we are about to remove the appVersion and move back the tag to the values to improve our release process. So once that change is merged the tag will be under values.yaml image.tag
5 participants
What this PR does / why we need it:
On each release of agent-control in k8s it sends to the metadata service that a new version is available
Which issue this PR fixes
Special notes for your reviewer:
This is the same that for other charts. The only difference is that for this one we need the
appVersionChecklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[mychartname])Release Notes to Publish (nr-k8s-otel-collector)
If this PR contains changes in
nr-k8s-otel-collector, please complete the following section. All other charts should ignore this section.🚀 What's Changed