Skip to content

feat: add metadata integration for agent-control-deployment #2179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jcoscollanr wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: add metadata integration for agent-control-deployment #2179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9857785
feat: add metadata integration for agent-control-deployment
jcoscollanr Mar 23, 2026
db187d8
Merge branch 'master' into feat/metadata-agent-control
jcoscollanr Mar 25, 2026
83e98d2
Merge branch 'master' into feat/metadata-agent-control
jcoscollanr Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions .github/workflows/post-release-agent-metadata.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ jobs:
- chart: pipeline-control-gateway
agent-type: PipelineControlGateway
config-directory: charts/pipeline-control-gateway/.fleetControl
- chart: agent-control-deployment
agent-type: NRAgentControl
config-directory: charts/agent-control-deployment/.fleetControl
fail-fast: false

steps:
Expand All @@ -51,14 +54,20 @@ jobs:
with:
ref: ${{ github.event.release.tag_name }}

- name: Extract version from release tag
- name: Extract version from release tag or Chart.yaml
if: steps.should-run.outputs.match == 'true'
id: version
run: |
VERSION="${{ github.event.release.tag_name }}"
VERSION="${VERSION#${{ matrix.chart }}-}"
if [[ "${{ matrix.chart }}" == "agent-control-deployment" ]]; then
VERSION=$(yq '.appVersion' charts/${{ matrix.chart }}/Chart.yaml | tr -d '"')
Copy link
Copy Markdown
Contributor

@gsanchezgavier gsanchezgavier Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcoscollanr we are about to remove the appVersion and move back the tag to the values to improve our release process. So once that change is merged the tag will be under values.yaml image.tag

echo "Extracted version from Chart.yaml appVersion: $VERSION"
Comment on lines +61 to +63
Copy link
Copy Markdown
Contributor

@sigilioso sigilioso Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the version we need is not .appVersion (which matches with the agent-control docker image) but .version which identifies this chart's version.

Copy link
Copy Markdown
Contributor Author

@jcoscollanr jcoscollanr Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, I did this on purpose.

The main idea is that we want the version to be the same as in the hosts, for the requirements. We can say this works with this version of agent-control

Copy link
Copy Markdown
Contributor

@sigilioso sigilioso Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have just discussed it offline, this version is not used for self-update but requirements therefore, we do need the appVersion which tells us that the version of the Agent Control binaries is available to be used in K8s. When working on the self-update experience, we will also need the chart-version.

else
VERSION="${{ github.event.release.tag_name }}"
VERSION="${VERSION#${{ matrix.chart }}-}"
echo "Extracted version from tag: $VERSION"
fi
echo "version=$VERSION" >> $GITHUB_OUTPUT
echo "Extracted version: $VERSION for chart ${{ matrix.chart }}"
echo "Final version: $VERSION for chart ${{ matrix.chart }}"

- name: Check .fleetControl directory
if: steps.should-run.outputs.match == 'true'
Expand Down
6 changes: 6 additions & 0 deletions charts/agent-control-deployment/.fleetControl/configurationDefinitions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Documentation: https://newrelic.atlassian.net/wiki/spaces/INST/pages/4609638833/CDD+Metadata+to+be+stored
configurationDefinitions:
- platform: KUBERNETESCLUSTER
description: agent control configuration
type: agent-control-config
version: 1.0.0
Loading