chore(fleetcontrol): use blank identifier for unused handler parameters#1795
Open
chore(fleetcontrol): use blank identifier for unused handler parameters#1795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The IDE was reporting "unused parameter" warnings across all 20
handle*functions in thefleetcontrolpackage.The
cmd *cobra.Commandandargs []stringparameters exist to satisfy theCommandHandlerinterface but are never used inside any handler body — the framework (command_framework.go) extracts and validates everything fromcmdinto theflagsargument before calling each handler.This PR replaces the named parameters with
_(Go's blank identifier) across all 20 handler files to silence the warnings and make the intent explicit.