Skip to content

chore(fleetcontrol): use blank identifier for unused handler parameters #1795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nandu-pns wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(fleetcontrol): use blank identifier for unused handler parameters #1795

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/fleetcontrol/fleet_configuration_create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import (
//
// Returns:
// - Error if configuration creation fails, nil on success
func handleFleetCreateConfiguration(cmd *cobra.Command, args []string, flags *FlagValues) error {
func handleFleetCreateConfiguration(_ *cobra.Command, _ []string, flags *FlagValues) error {
// Get typed flag values - no hardcoded strings!
// Note: CreateConfiguration() returns error because it handles file reading
f, err := flags.CreateConfiguration()
Expand Down
2 changes: 1 addition & 1 deletion internal/fleetcontrol/fleet_configuration_delete.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import (
//
// Returns:
// - Error if configuration deletion fails, nil on success
func handleFleetDeleteConfiguration(cmd *cobra.Command, args []string, flags *FlagValues) error {
func handleFleetDeleteConfiguration(_ *cobra.Command, _ []string, flags *FlagValues) error {
// Get typed flag values - no hardcoded strings!
f := flags.DeleteConfiguration()

Expand Down
2 changes: 1 addition & 1 deletion internal/fleetcontrol/fleet_configuration_get.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ import (
//
// Returns:
// - Error if configuration retrieval fails, nil on success
func handleFleetGetConfiguration(cmd *cobra.Command, args []string, flags *FlagValues) error {
func handleFleetGetConfiguration(_ *cobra.Command, _ []string, flags *FlagValues) error {
// Get typed flag values - no hardcoded strings!
f := flags.GetConfiguration()

Expand Down
2 changes: 1 addition & 1 deletion internal/fleetcontrol/fleet_configuration_version_add.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import (
//
// Returns:
// - Error if version addition fails, nil on success
func handleFleetAddVersion(cmd *cobra.Command, args []string, flags *FlagValues) error {
func handleFleetAddVersion(_ *cobra.Command, _ []string, flags *FlagValues) error {
// Get typed flag values - no hardcoded strings!
// Note: AddVersion() returns error because it handles file reading
f, err := flags.AddVersion()
Expand Down
2 changes: 1 addition & 1 deletion internal/fleetcontrol/fleet_configuration_version_delete.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import (
//
// Returns:
// - Error if version deletion fails, nil on success
func handleFleetDeleteVersion(cmd *cobra.Command, args []string, flags *FlagValues) error {
func handleFleetDeleteVersion(_ *cobra.Command, _ []string, flags *FlagValues) error {
// Get typed flag values - no hardcoded strings!
f := flags.DeleteVersion()

Expand Down
2 changes: 1 addition & 1 deletion internal/fleetcontrol/fleet_configuration_version_list.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import (
//
// Returns:
// - Error if version retrieval fails, nil on success
func handleFleetGetConfigurationVersions(cmd *cobra.Command, args []string, flags *FlagValues) error {
func handleFleetGetConfigurationVersions(_ *cobra.Command, _ []string, flags *FlagValues) error {
// Get typed flag values - no hardcoded strings!
f := flags.GetVersions()

Expand Down
2 changes: 1 addition & 1 deletion internal/fleetcontrol/fleet_deployment_create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ import (
//
// Returns:
// - Error if deployment creation fails, nil on success
func handleFleetCreateDeployment(cmd *cobra.Command, args []string, flags *FlagValues) error {
func handleFleetCreateDeployment(_ *cobra.Command, _ []string, flags *FlagValues) error {
// Get typed flag values - no hardcoded strings!
f := flags.CreateDeployment()

Expand Down
2 changes: 1 addition & 1 deletion internal/fleetcontrol/fleet_deployment_delete.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import (
//
// Returns:
// - Error if deployment deletion fails, nil on success
func handleFleetDeleteDeployment(cmd *cobra.Command, args []string, flags *FlagValues) error {
func handleFleetDeleteDeployment(_ *cobra.Command, _ []string, flags *FlagValues) error {
// Get typed flag values - no hardcoded strings!
f := flags.DeleteDeployment()

Expand Down
2 changes: 1 addition & 1 deletion internal/fleetcontrol/fleet_deployment_deploy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ func spinner(duration time.Duration, message string) {
// could affect the code-perception of the hierarchical structure of the fleet commands
//
//nolint:gocyclo
func handleFleetDeploy(cmd *cobra.Command, args []string, flags *FlagValues) error {
func handleFleetDeploy(_ *cobra.Command, _ []string, flags *FlagValues) error {
// Get typed flag values - no hardcoded strings!
f := flags.Deploy()

Expand Down
2 changes: 1 addition & 1 deletion internal/fleetcontrol/fleet_deployment_update.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ import (
//
// Returns:
// - Error if deployment update fails, nil on success
func handleFleetUpdateDeployment(cmd *cobra.Command, args []string, flags *FlagValues) error {
func handleFleetUpdateDeployment(_ *cobra.Command, _ []string, flags *FlagValues) error {
// Get typed flag values - no hardcoded strings!
f := flags.UpdateDeployment()

Expand Down
2 changes: 1 addition & 1 deletion internal/fleetcontrol/fleet_entities_get_managed.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ type EntityOutput struct {
//
// Returns:
// - Error if search fails, nil on success
func handleFleetGetManagedEntities(cmd *cobra.Command, args []string, flags *FlagValues) error {
func handleFleetGetManagedEntities(_ *cobra.Command, _ []string, flags *FlagValues) error {
// Get typed flag values
f := flags.GetManaged()

Expand Down
2 changes: 1 addition & 1 deletion internal/fleetcontrol/fleet_entities_get_unassigned.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ import (
//
// Returns:
// - Error if search fails, nil on success
func handleFleetGetUnassignedEntities(cmd *cobra.Command, args []string, flags *FlagValues) error {
func handleFleetGetUnassignedEntities(_ *cobra.Command, _ []string, flags *FlagValues) error {
// Get typed flag values
f := flags.GetUnassigned()

Expand Down
2 changes: 1 addition & 1 deletion internal/fleetcontrol/fleet_management_create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ import (
//
// Returns:
// - Error if fleet creation fails, nil on success
func handleFleetCreate(cmd *cobra.Command, args []string, flags *FlagValues) error {
func handleFleetCreate(_ *cobra.Command, _ []string, flags *FlagValues) error {
// Get typed flag values - no hardcoded strings!
f := flags.Create()

Expand Down
2 changes: 1 addition & 1 deletion internal/fleetcontrol/fleet_management_delete.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import (
//
// Returns:
// - Error if validation fails or deletion fails, nil on success
func handleFleetDelete(cmd *cobra.Command, args []string, flags *FlagValues) error {
func handleFleetDelete(_ *cobra.Command, _ []string, flags *FlagValues) error {
// Get typed flag values
f := flags.Delete()

Expand Down
2 changes: 1 addition & 1 deletion internal/fleetcontrol/fleet_management_get.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import (
//
// Returns:
// - Error if fleet retrieval fails, nil on success
func handleFleetGet(cmd *cobra.Command, args []string, flags *FlagValues) error {
func handleFleetGet(_ *cobra.Command, _ []string, flags *FlagValues) error {
// Get typed flag values
f := flags.Get()

Expand Down
2 changes: 1 addition & 1 deletion internal/fleetcontrol/fleet_management_search.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ import (
//
// Returns:
// - Error if search fails, nil on success
func handleFleetSearch(cmd *cobra.Command, args []string, flags *FlagValues) error {
func handleFleetSearch(_ *cobra.Command, _ []string, flags *FlagValues) error {
// Get typed flag values
f := flags.Search()

Expand Down
2 changes: 1 addition & 1 deletion internal/fleetcontrol/fleet_management_update.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import (
//
// Returns:
// - Error if fleet update fails, nil on success
func handleFleetUpdate(cmd *cobra.Command, args []string, flags *FlagValues) error {
func handleFleetUpdate(_ *cobra.Command, _ []string, flags *FlagValues) error {
// Get typed flag values - no hardcoded strings!
f := flags.Update()

Expand Down
2 changes: 1 addition & 1 deletion internal/fleetcontrol/fleet_members_add.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import (
//
// Returns:
// - Error if adding members fails, nil on success
func handleFleetAddMembers(cmd *cobra.Command, args []string, flags *FlagValues) error {
func handleFleetAddMembers(_ *cobra.Command, _ []string, flags *FlagValues) error {
// Get typed flag values - no hardcoded strings!
f := flags.AddMembers()

Expand Down
2 changes: 1 addition & 1 deletion internal/fleetcontrol/fleet_members_list.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ type FleetMembersResultWithoutTags struct {
//
// Returns:
// - Error if listing members fails, nil on success
func handleFleetListMembers(cmd *cobra.Command, args []string, flags *FlagValues) error {
func handleFleetListMembers(_ *cobra.Command, _ []string, flags *FlagValues) error {
// Get typed flag values - no hardcoded strings!
f := flags.ListMembers()

Expand Down
2 changes: 1 addition & 1 deletion internal/fleetcontrol/fleet_members_remove.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import (
//
// Returns:
// - Error if removing members fails, nil on success
func handleFleetRemoveMembers(cmd *cobra.Command, args []string, flags *FlagValues) error {
func handleFleetRemoveMembers(_ *cobra.Command, _ []string, flags *FlagValues) error {
// Get typed flag values - no hardcoded strings!
f := flags.RemoveMembers()

Expand Down
Loading