chore(utils): Cleanup dependencies and fix cockatiel API#2763
Closed
praveenkatha-nr wants to merge 1 commit intoreleasefrom
Closed
chore(utils): Cleanup dependencies and fix cockatiel API#2763praveenkatha-nr wants to merge 1 commit intoreleasefrom
praveenkatha-nr wants to merge 1 commit intoreleasefrom
Conversation
praveenkatha-nr
force-pushed
the
chore/cleanup-types-and-lockfile
branch
2 times, most recently
from
5bf107c to
3390184
Compare
- Remove package-lock.json to fix mixed package manager warning - Remove unnecessary @types packages (glob, node-fetch, uuid, lodash, prompt-sync) - Add @types/lodash.get for the lodash.get package - Update cockatiel retry API to match v3.x breaking changes - Fix TypeScript unknown type errors in nr-graphql-helpers.ts and github-api-helpers.ts - Fix lodash/get import to use lodash.get package - Fix Jest 30 API changes (toBeCalled -> toHaveBeenCalled) - Add jest.setup.js to mock node-fetch and @actions/core for Node.js 22 compatibility - Sort glob results in Alert.ts for consistent test ordering - Fix fs mock in validate_images.test.js to include realpathSync.native for path-scurry - Add .nvmrc specifying Node.js 22 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
praveenkatha-nr
force-pushed
the
chore/cleanup-types-and-lockfile
branch
from
3390184 to
03d44b4
Compare
praveenkatha-nr
added a commit
that referenced
this pull request
Jan 27, 2026
- Add jest.setup.js with @actions/core mock for test isolation - Add setupFiles config to jest.config.js - Fix cockatiel retry API order (.exponential().attempts() instead of .attempts().exponential()) - Fix github-api-helpers.ts response handling (check resp.ok before parsing JSON) - Add .sort() to glob results in Alert.ts for deterministic ordering - Update Jest assertions for v29 compatibility: - toBeCalled -> toHaveBeenCalled - toBeCalledTimes -> toHaveBeenCalledTimes - Update fs mock in validate_images.test.js to use jest.requireActual Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A concise description of the changes being introduced. Please review the pre-merge checklist section to validate this pull request is ready for review and merge. If it is not ready, please mark the pull request as a draft.
The owners of this repo are not experts in the subject matter of the quickstarts. We review for the quickstart to be functional and for security risks. If you are seeking feedback on the content of the quickstart, please seek out a subject matter expert. If you are not an internal NR contributor, we can do our best to connect you with a content reviewer.
Pre merge checklist
Dashboards
Alerts