chore: test ci optimizations #360
Conversation
mailo-nr
force-pushed
the
marsac/ci-opt
branch
4 times, most recently
from
bf98d38 to
ceecfa2
Compare
.github/workflows/ci-base.yaml
Outdated
| # Base hash for source generation (inputs that affect generation) | ||
| SOURCE_HASH="${{ hashFiles('distributions/${{ inputs.distribution }}/manifest.yaml', 'distributions/${{ inputs.distribution }}/_build/go.mod', 'distributions/${{ inputs.distribution }}/_build/go.sum', 'Makefile') }}" | ||
| # Extended hash for Docker build (includes generated sources) | ||
| DOCKER_HASH="${{ hashFiles('distributions/${{ inputs.distribution }}/Dockerfile', 'distributions/${{ inputs.distribution }}/manifest.yaml', 'distributions/${{ inputs.distribution }}/_build/go.mod', 'distributions/${{ inputs.distribution }}/_build/go.sum') }}" |
There was a problem hiding this comment.
Embedded configs probably need to be part of the docker hash, right?
There was a problem hiding this comment.
ooh, yes, good catch
| if [ ${{ inputs.nightly }} = "true" ]; then | ||
| echo "image_tag=$VERSION-nightly-$ARCH" >> $GITHUB_ENV | ||
| else | ||
| echo "image_tag=$VERSION-$ARCH" >> $GITHUB_ENV |
There was a problem hiding this comment.
The else block is in conflict with the entire step being condition on nightly?
mailo-nr
force-pushed
the
marsac/ci-opt
branch
2 times, most recently
from
98a43e6 to
907a478
Compare
| ~/go/pkg/mod | ||
| key: ${{ steps.build-cache-keys.outputs.binary_key }} | ||
| restore-keys: | | ||
| goreleaser-build-${{ inputs.distribution }}- |
There was a problem hiding this comment.
The binary_key doesn't have the goreleaser-build- prefix, so will this ever hit anything?
| # Fallback version | ||
| VERSION="cached-$(date +%Y%m%d-%H%M)" | ||
| echo "⚠️ Warning: No metadata found, using fallback version: $VERSION" |
There was a problem hiding this comment.
Have we encountered this? Is this to have a fallback when goreleaser changes where it writes its metadata or is there a different scenario I am not thinking of? I am wondering if we should just fail the build instead of semi-silently continue?
There was a problem hiding this comment.
Didn't encounter it but didn't want a scenario where build cache could get corrupted. I'm fine taking this out and we see if it's something we run into
No description provided.