OBJ, DAE: Added SetFamilyType in UsdGeom.Subset #64
+34
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
| self.assertEqual(element_type, UsdGeom.Tokens.face) | ||
| family_name = subset.GetFamilyNameAttr().Get() | ||
| self.assertEqual(family_name, UsdShade.Tokens.materialBind) | ||
| family_type = subset.GetFamilyType(UsdGeom.Mesh(box_materials_prim), family_name) |
Member
There was a problem hiding this comment.
We should also assert ValidateFamily on the mesh to ensure that partition was the correct familyType to use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #52
I specified
SetFamilyTypewhen creating GeomSubset in OBJ and DAE.unit tests: tests/testMaterial.py - test_mesh_subsets_materials
Added a process to check
ElementType/FamilyName/FamilyTypeto the OBJ and DAE Subset unit tests.Checklist