Skip to content

Conversation

@GVodyanov
Copy link
Contributor

The selecting wasn't working

@GVodyanov GVodyanov self-assigned this Oct 19, 2025
@GVodyanov GVodyanov requested a review from hamza221 as a code owner October 19, 2025 20:03
@GVodyanov GVodyanov added the 3. to review Waiting for reviews label Oct 19, 2025
@codecov
Copy link

codecov bot commented Oct 19, 2025

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ts/AppNavigation/Settings/SettingsSortContacts.vue 0.00% 5 Missing ⚠️

📢 Thoughts on this report? Let us know!

@GVodyanov
Copy link
Contributor Author

/backport to stable8.0

@GVodyanov GVodyanov force-pushed the fix/sorting-contacts-ncselect branch from 51c3e45 to a66bc1e Compare October 19, 2025 20:10
@SebastianKrupinski
Copy link
Contributor

Tested. But there is a bug.

image
  • Select a sort order
  • Then save and close the settings modal
  • Re-open the settings modal

The key is show and not the option label

@hamza221 hamza221 linked an issue Nov 10, 2025 that may be closed by this pull request
@GVodyanov GVodyanov force-pushed the fix/sorting-contacts-ncselect branch from a66bc1e to 994ceaf Compare November 17, 2025 09:03
@GVodyanov
Copy link
Contributor Author

Tested. But there is a bug.
image

* Select a sort order

* Then save and close the settings modal

* Re-open the settings modal

The key is show and not the option label

Fixed!

@hamza221
Copy link
Contributor

/backport to stable8.2

@hamza221 hamza221 merged commit 5531e65 into main Nov 17, 2025
42 of 43 checks passed
@hamza221 hamza221 deleted the fix/sorting-contacts-ncselect branch November 17, 2025 12:05
@backportbot
Copy link

backportbot bot commented Nov 17, 2025

The backport to stable8.2 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable8.2
git pull origin stable8.2

# Create the new backport branch
git checkout -b backport/4804/stable8.2

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 994ceafe

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/4804/stable8.2

Error: Failed to clone repository: Failed to create working tree: Preparing worktree (new branch 'backport/4804/stable8.2')
fatal: not a valid object name: 'origin/stable8.2'


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@hamza221
Copy link
Contributor

/backport to stable8.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sort by does not work

4 participants