Skip to content

Conversation

@camilasan
Copy link
Member

@camilasan camilasan commented Jun 3, 2024

Fix https://github.com/nextcloud-gmbh/desktop/issues/26

This should:

  • check for server capability
    hasValidSubscription' => true,
    desktopEnterpriseChannel => stable/enterprise

  • if set -> Desktop asks update server for channel=enterprise

  • it is automatically enabled for all customer

  • user can still "downgrade" to stable (will then be remembered)

  • if the client is branded:

    • the option is always set to "stable"
    • do not upgrade to "enterprise"

@camilasan camilasan force-pushed the feature/update-channel-2 branch from 53b6f9b to b88d1dd Compare June 3, 2024 19:37
@camilasan camilasan force-pushed the feature/update-channel-2 branch 3 times, most recently from 106bb08 to 952526a Compare July 3, 2024 22:22
@camilasan camilasan requested review from claucambra and mgallien July 3, 2024 22:22
@camilasan camilasan force-pushed the feature/update-channel-2 branch from 952526a to 206b815 Compare July 3, 2024 22:28
@camilasan camilasan force-pushed the feature/update-channel-2 branch from 5b5f6a7 to 926d060 Compare July 4, 2024 08:15
camilasan added 19 commits July 4, 2024 10:16
Signed-off-by: Camila Ayres <[email protected]>
The default should be what is returned by defaultUpdateChannel()
when desktopEnterpriseChannel is not available.

Signed-off-by: Camila Ayres <[email protected]>
…nd what info to show the user.

Signed-off-by: Camila Ayres <[email protected]>
Subscription and channel are supposed to be a general setting, not per user.

Signed-off-by: Camila Ayres <[email protected]>
@camilasan camilasan force-pushed the feature/update-channel-2 branch from 926d060 to 9bd4ef1 Compare July 4, 2024 08:16
@camilasan camilasan marked this pull request as ready for review July 4, 2024 08:20
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6790-9bd4ef1b83e1e7a93bc3017f01980e02ab739dfa-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@camilasan camilasan merged commit cb47b1b into master Jul 4, 2024
@camilasan camilasan deleted the feature/update-channel-2 branch July 4, 2024 09:15
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
50.0% Coverage on New Code (required ≥ 80%)
B Maintainability Rating on New Code (required ≥ A)
35 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants