UserStatusSelector: set focusPolicy on accept button #7906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise the status text won't be set on macOS as the text box never loses its focus `Qt.StrongFocus` is the default focusPolicy on all platforms except for macOS, there it's `Qt.TabFocus` the other buttons of the UserStatusSelector don't need that focusPolicy as they do not modify the model from values in the view see also: - https://bugreports.qt.io/browse/QTBUG-110295 - https://codebrowser.dev/qt6/qtdeclarative/src/quicktemplates/qquickabstractbutton.cpp.html#_ZN27QQuickAbstractButtonPrivate4initEv Signed-off-by: Jyrki Gadinger <[email protected]>
nilsding
added
os: 🍎 macOS
feature: ☁️ GUI
|
/backport to stable-3.16 |
|
Artifact containing the AppImage: nextcloud-appimage-pr-7906.zip SHA256 checksum: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
mgallien
approved these changes
Feb 21, 2025
Rello
approved these changes
Feb 21, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otherwise the status text won't be set on macOS as the text box never loses its focus
Qt.StrongFocusis the default focusPolicy on all platforms except for macOS, there it'sQt.TabFocusthe other buttons of the UserStatusSelector don't need that focusPolicy as they do not modify the model from values in the view
see also: