Skip to content

fix Unix socket syntax #13173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix Unix socket syntax #13173

wants to merge 1 commit into from

Conversation

leManu
Copy link

@leManu leManu commented Jun 2, 2025

☑️ Resolves

🖼️ Screenshots

Screenshot 2025-06-02 at 12-03-59 documentation_admin_manual_configuration_server_config_sample_php_parameters rst at master · leManu_documentation
Screenshot 2025-06-02 at 12-04-54 documentation_admin_manual_configuration_database_linux_database_configuration rst at master · leManu_documentation

@leManu leManu requested a review from nickvergessen as a code owner June 2, 2025 10:05
nickvergessen
nickvergessen reviewed Jun 2, 2025
View reviewed changes
admin_manual/configuration_server/config_sample_php_parameters.rst
@@ -336,7 +336,7 @@ Your host server name, for example ``localhost``, ``hostname``,
``hostname.example.com``, or the IP address.

To specify a port use ``hostname:####``, for IPv6 addresses use the URI notation ``[ip]:port``.
To specify a Unix socket use ``/path/to/directory/containing/socket``, e.g. ``/run/postgresql/``.
To specify a Unix socket use ``localhost:/path/to/directory/containing/socket`` or ``:/path/to/directory/containing/socket``, e.g. ``localhost:/run/postgresql/``.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is generated. Instead you must modify https://github.com/nextcloud/server/blob/master/config/config.sample.php#L123

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nickvergessen, I opened a new PR : nextcloud/server#53327

Guess that will be sufficient ?

@joshtrichards joshtrichards self-requested a review June 2, 2025 15:16
@leManu leManu mentioned this pull request Jun 4, 2025
Merged
nickvergessen
nickvergessen reviewed Jun 6, 2025
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

admin_manual/configuration_database/linux_database_configuration.rst change is good, the other one needs to be reverted and will come automatically from your server PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@skjnldsv skjnldsv skjnldsv approved these changes

@joshtrichards joshtrichards Awaiting requested review from joshtrichards

Assignees
No one assigned
Labels
3. to review bug manual: admin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Socket syntax unclear for dbhost variable
4 participants
@leManu @nickvergessen @skjnldsv @joshtrichards