Skip to content

fix Unix socket syntax #53327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2025
Merged

fix Unix socket syntax #53327

merged 1 commit into from
Jun 6, 2025

Conversation

leManu
Copy link
Contributor

@leManu leManu commented Jun 4, 2025

@leManu leManu requested a review from a team as a code owner June 4, 2025 20:08
@leManu leManu requested review from artonge, nfebe and skjnldsv and removed request for a team June 4, 2025 20:08
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches the tests:

public static function splitHostFromPortAndSocketData(): array {
return [
['127.0.0.1', ['host' => '127.0.0.1']],
['db.example.org', ['host' => 'db.example.org']],
['unix', ['host' => 'unix']],
['[::1]', ['host' => '[::1]']],
['127.0.0.1:3306', ['host' => '127.0.0.1', 'port' => 3306]],
['db.example.org:3306', ['host' => 'db.example.org', 'port' => 3306]],
['unix:3306', ['host' => 'unix', 'port' => 3306]],
['[::1]:3306', ['host' => '[::1]', 'port' => 3306]],
['unix:/socket', ['host' => 'unix', 'unix_socket' => '/socket']],
];
}

@nickvergessen nickvergessen added this to the Nextcloud 32 milestone Jun 6, 2025
@nickvergessen nickvergessen added the 3. to review Waiting for reviews label Jun 6, 2025
@skjnldsv skjnldsv merged commit ed34254 into nextcloud:master Jun 6, 2025
174 of 180 checks passed
Copy link

welcome bot commented Jun 6, 2025

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Socket syntax unclear for dbhost variable
3 participants