fix(SecureView): hide disfunctional *download* files action #5171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to 🧭 Planning evaluation (don't pick)
in 📝 Office team
blizzz
moved this from 🧭 Planning evaluation (don't pick)
to 🏗️ In progress
in 📝 Office team
blizzz
commented
Nov 13, 2025
| // FIXME: coordinate with Files how a better solution looks like. Maybe by setting it only to 'true' by any provider? To avoid overwriting. Or throwing a dedicated event in just this case? | ||
| $propFind->set(FilesPlugin::SHARE_HIDE_DOWNLOAD_PROPERTYNAME, 'true'); | ||
| // avoid potential race condition with FilesPlugin that may set it to "false" | ||
| $propFind->handle(FilesPlugin::SHARE_HIDE_DOWNLOAD_PROPERTYNAME, 'true'); |
Member
Author
There was a problem hiding this comment.
@susnux this works, but is uncomfortably hacky. Maybe sufficient for 32 and 31, but what do you think of making the dav app emit an event here and stay the whole owner of that attribute? Listeners can then mark a node download-hidden only.
Contributor
There was a problem hiding this comment.
I am not that sure because for the DAV part probably @salmart-dev or @CarlSchwan would be good to also include in the process.
blizzz
force-pushed
the
fix/5170/hide-download-button-on-secure-view
branch
from
901762a to
2896f1e
Compare
blizzz
force-pushed
the
fix/5170/hide-download-button-on-secure-view
branch
from
2896f1e to
9301da6
Compare
This is achieved by setting a specific DAV attribute. At the moment there is one handler in dav-apps FilesPlugin and it could overwrite the value with "false". We make sure not to downgrade here and prevent downgrade from dav (possible race condition). Signed-off-by: Arthur Schiwon <[email protected]>
blizzz
force-pushed
the
fix/5170/hide-download-button-on-secure-view
branch
from
58974e7 to
3b27369
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is achieved by setting a specific DAV attribute. At the moment there is one handler in dav-apps FilesPlugin and it could overwrite the value with "false". We make sure not to downgrade here and prevent downgrade from dav (possible race condition).
Summary
TODO
Checklist