fix(account menu): avoid having duplicate IDs for account menu entries without href links #55330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcitworld
requested review from
nfebe,
susnux and
szaimen
and removed request for
a team
Member
Author
|
/compile amend / |
nextcloud-command
force-pushed
the
fix-duplicate-id-on-account-menu-entry
branch
from
db88763 to
11fe39f
Compare
…s without href links When the account menu entry doesn't have an href property (for instance the entry added by First Run Wizard), the ID is duplicated between the list item and the <a> tag it contains Signed-off-by: Thomas Citharel <[email protected]>
tcitworld
force-pushed
the
fix-duplicate-id-on-account-menu-entry
branch
from
11fe39f to
9403880
Compare
Member
Author
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
Member
Author
|
Cypress failure seems related |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the account menu entry doesn't have an
hrefproperty (for instance the entry added by First Run Wizard), the ID is duplicated between the list item and the<a>tag it contains.Checklist
3. to review, feature component)stable32)