Skip to content

fix: Get rid of ajax endpoints in user_ldap #55518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Nov 21, 2025
Merged

fix: Get rid of ajax endpoints in user_ldap #55518

merged 20 commits into from
Nov 21, 2025

Conversation

@come-nc
Copy link
Contributor

@come-nc come-nc commented Oct 2, 2025

  • Resolves: #

Summary

TODO

  • ...

Checklist

@come-nc come-nc self-assigned this Oct 2, 2025
@come-nc come-nc added this to the Nextcloud 33 milestone Oct 2, 2025
@come-nc come-nc requested review from artonge and susnux October 2, 2025 14:54
@come-nc
Copy link
Contributor Author

come-nc commented Oct 6, 2025

Should be rebased after #55576
It seems to work apart from that.

@come-nc come-nc force-pushed the fix/ldap-get-rid-of-ajax branch 4 times, most recently from d4eab7e to 514d18c Compare October 7, 2025 10:05
come-nc
come-nc commented Oct 7, 2025
View reviewed changes
@come-nc
Copy link
Contributor Author

come-nc commented Oct 7, 2025

/compile /

susnux
susnux reviewed Oct 7, 2025
View reviewed changes
apps/testing/ajax/endpoint.php
Copy link
Contributor

@susnux susnux Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed, do the tests still make sense?

Copy link
Contributor Author

@come-nc come-nc Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, no idea, but I guess so. Any application could still use php endpoints and rely on the url generator, no?

@come-nc
Copy link
Contributor Author

come-nc commented Oct 7, 2025

/compile rebase

@nextcloud-command nextcloud-command force-pushed the fix/ldap-get-rid-of-ajax branch from 0791a12 to 28eab7d Compare October 7, 2025 15:15
@come-nc come-nc force-pushed the fix/ldap-get-rid-of-ajax branch from 28eab7d to c1f229c Compare October 16, 2025 15:33
@come-nc
Copy link
Contributor Author

come-nc commented Oct 16, 2025

/compile rebase

@come-nc come-nc force-pushed the fix/ldap-get-rid-of-ajax branch from deba764 to 424d775 Compare October 20, 2025 07:10
@come-nc
Copy link
Contributor Author

come-nc commented Oct 20, 2025

/compile /

@come-nc come-nc marked this pull request as ready for review October 20, 2025 07:10
@come-nc come-nc requested review from a team and provokateurin as code owners October 20, 2025 07:10
@come-nc come-nc requested review from ArtificialOwl and skjnldsv and removed request for a team October 20, 2025 07:10
@come-nc
Copy link
Contributor Author

come-nc commented Oct 21, 2025

I will wait for reviews before doing compile/rebase again to not waste CI time.

@come-nc come-nc mentioned this pull request Oct 21, 2025
Open
8 tasks
susnux
susnux approved these changes Oct 21, 2025
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good

@artonge artonge force-pushed the fix/ldap-get-rid-of-ajax branch from 6fa90ab to 89e8df3 Compare November 21, 2025 13:21
@artonge
Copy link
Contributor

artonge commented Nov 21, 2025 •
edited
Loading

Rebased, and added a few fixes.

Tested, and all seems fine.

come-nc and others added 20 commits November 21, 2025 14:23
@come-nc @artonge
chore: Get rid of unused user_ldap AJAX endpoints
2dea21a 
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Louis Chmn <[email protected]>
@come-nc @artonge
fix(user_ldap): Add OCS endpoint for testing configurations
e842874 
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Louis Chmn <[email protected]>
@come-nc @artonge
fix(user_ldap): Add OCS endpoint for copying configurations
36475f2 
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Louis Chmn <[email protected]>
@come-nc @artonge
feat(user_ldap): Add a wizard OCS API
a0e5548 
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Louis Chmn <[email protected]>
@artonge
feat(user_ldap): Adapt frontend to call new endpoints
777c729 
Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chmn <[email protected]>
@come-nc @artonge
fix(ldap): Fix wizard controller action route
9d41d81 
It seems naming a route parameter $action causes issue, so renamed it to
 $wizardAction.

Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Louis Chmn <[email protected]>
@come-nc @artonge
chore: Fix typing in WizardResult
ac078b6 
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Louis Chmn <[email protected]>
@come-nc @artonge
fix: Fix documentation for controllers and update openapi.json
c414a7b 
Also removed save action from WizardController as there is already a
 route in ConfigApiController to save a configuration.

Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Louis Chmn <[email protected]>
@come-nc @artonge
fix(ldap): Add OCS route for clearing mapping without using ajax
28cef3e 
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Louis Chmn <[email protected]>
@come-nc @artonge
chore(user_ldap): Remove ajax endpoints
c621662 
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Louis Chmn <[email protected]>
@come-nc @artonge
fix(user_ldap): Remove last ajax call from frontend
aed0e82 
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Louis Chmn <[email protected]>
@come-nc @artonge
chore: Update psalm baseline
92efa01 
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Louis Chmn <[email protected]>
@come-nc @artonge
fix(tests): Use testing application for testing ajax endpoints, not u…
f9abfe0 
…ser_ldap

Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Louis Chmn <[email protected]>
@come-nc @artonge
chore: npm run lint:fix
00349e6 
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Louis Chmn <[email protected]>
@come-nc @artonge
chore: remove unused imports
1afa2a5 
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Louis Chmn <[email protected]>
@come-nc @artonge
fix(user_ldap): Call config API instead of wizard save action
687fa0a 
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Louis Chmn <[email protected]>
@artonge
feat(user_ldap): Save base on detect
3906998 
Signed-off-by: Louis Chmn <[email protected]>
@artonge
feat(user_ldap): Disable countInBaseDN button when base is empty
f57fb6e 
Signed-off-by: Louis Chmn <[email protected]>
@artonge
fix(user_ldap): Properly handle new wizard OCS endpoint error
ac690ea 
Signed-off-by: Louis Chmn <[email protected]>
@artonge
chore: Compile assets
e9b1e7a 
Signed-off-by: Louis Chmn <[email protected]>
@artonge artonge force-pushed the fix/ldap-get-rid-of-ajax branch from 89e8df3 to e9b1e7a Compare November 21, 2025 13:24
@artonge artonge mentioned this pull request Nov 21, 2025
Open
5 tasks
@artonge artonge merged commit e98864b into master Nov 21, 2025
238 of 252 checks passed
@artonge artonge deleted the fix/ldap-get-rid-of-ajax branch November 21, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@artonge artonge artonge approved these changes

@provokateurin provokateurin Awaiting requested review from provokateurin provokateurin is a code owner

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner automatically assigned from nextcloud/server-frontend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-frontend

Assignees

@come-nc come-nc

Labels

3. to review Waiting for reviews feature: ldap technical debt

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

5 participants

@come-nc @skjnldsv @artonge @susnux