Skip to content

fix: Get rid of ajax endpoints in user_ldap #55518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Nov 21, 2025
Merged

fix: Get rid of ajax endpoints in user_ldap #55518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
2dea21a
chore: Get rid of unused user_ldap AJAX endpoints
come-nc Oct 2, 2025
e842874
fix(user_ldap): Add OCS endpoint for testing configurations
come-nc Oct 2, 2025
36475f2
fix(user_ldap): Add OCS endpoint for copying configurations
come-nc Oct 2, 2025
a0e5548
feat(user_ldap): Add a wizard OCS API
come-nc Oct 2, 2025
777c729
feat(user_ldap): Adapt frontend to call new endpoints
artonge Oct 2, 2025
9d41d81
fix(ldap): Fix wizard controller action route
come-nc Oct 6, 2025
ac078b6
chore: Fix typing in WizardResult
come-nc Oct 7, 2025
c414a7b
fix: Fix documentation for controllers and update openapi.json
come-nc Oct 7, 2025
28cef3e
fix(ldap): Add OCS route for clearing mapping without using ajax
come-nc Oct 7, 2025
c621662
chore(user_ldap): Remove ajax endpoints
come-nc Oct 7, 2025
aed0e82
fix(user_ldap): Remove last ajax call from frontend
come-nc Oct 7, 2025
92efa01
chore: Update psalm baseline
come-nc Oct 7, 2025
f9abfe0
fix(tests): Use testing application for testing ajax endpoints, not u…
come-nc Oct 7, 2025
00349e6
chore: npm run lint:fix
come-nc Oct 7, 2025
1afa2a5
chore: remove unused imports
come-nc Oct 7, 2025
687fa0a
fix(user_ldap): Call config API instead of wizard save action
come-nc Oct 7, 2025
3906998
feat(user_ldap): Save base on detect
artonge Nov 21, 2025
f57fb6e
feat(user_ldap): Disable countInBaseDN button when base is empty
artonge Nov 21, 2025
ac690ea
fix(user_ldap): Properly handle new wizard OCS endpoint error
artonge Nov 21, 2025
e9b1e7a
chore: Compile assets
artonge Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions apps/testing/ajax/endpoint.php
View file
Open in desktop
Copy link
Contributor

@susnux susnux Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed, do the tests still make sense?

Copy link
Contributor Author

@come-nc come-nc Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, no idea, but I guess so. Any application could still use php endpoints and rely on the url generator, no?

Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?php

declare(strict_types=1);

/**
* SPDX-FileCopyrightText: 2025 Nextcloud GmbH and Nextcloud contributors
* SPDX-License-Identifier: AGPL-3.0-or-later
*/

// Fake ajax endpoint for testing url generator
53 changes: 0 additions & 53 deletions apps/user_ldap/ajax/clearMappings.php
View file
Open in desktop

This file was deleted.

24 changes: 0 additions & 24 deletions apps/user_ldap/ajax/deleteConfiguration.php
View file
Open in desktop

This file was deleted.

23 changes: 0 additions & 23 deletions apps/user_ldap/ajax/getConfiguration.php
View file
Open in desktop

This file was deleted.

33 changes: 0 additions & 33 deletions apps/user_ldap/ajax/getNewServerConfigPrefix.php
View file
Open in desktop

This file was deleted.

32 changes: 0 additions & 32 deletions apps/user_ldap/ajax/setConfiguration.php
View file
Open in desktop

This file was deleted.

76 changes: 0 additions & 76 deletions apps/user_ldap/ajax/testConfiguration.php
View file
Open in desktop

This file was deleted.

120 changes: 0 additions & 120 deletions apps/user_ldap/ajax/wizard.php
View file
Open in desktop

This file was deleted.

14 changes: 0 additions & 14 deletions apps/user_ldap/appinfo/routes.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,20 +7,6 @@
* SPDX-FileCopyrightText: 2016 ownCloud, Inc.
* SPDX-License-Identifier: AGPL-3.0-only
*/
$this->create('user_ldap_ajax_clearMappings', 'apps/user_ldap/ajax/clearMappings.php')
->actionInclude('user_ldap/ajax/clearMappings.php');
$this->create('user_ldap_ajax_deleteConfiguration', 'apps/user_ldap/ajax/deleteConfiguration.php')
->actionInclude('user_ldap/ajax/deleteConfiguration.php');
$this->create('user_ldap_ajax_getConfiguration', 'apps/user_ldap/ajax/getConfiguration.php')
->actionInclude('user_ldap/ajax/getConfiguration.php');
$this->create('user_ldap_ajax_getNewServerConfigPrefix', 'apps/user_ldap/ajax/getNewServerConfigPrefix.php')
->actionInclude('user_ldap/ajax/getNewServerConfigPrefix.php');
$this->create('user_ldap_ajax_setConfiguration', 'apps/user_ldap/ajax/setConfiguration.php')
->actionInclude('user_ldap/ajax/setConfiguration.php');
$this->create('user_ldap_ajax_testConfiguration', 'apps/user_ldap/ajax/testConfiguration.php')
->actionInclude('user_ldap/ajax/testConfiguration.php');
$this->create('user_ldap_ajax_wizard', 'apps/user_ldap/ajax/wizard.php')
->actionInclude('user_ldap/ajax/wizard.php');

return [
'routes' => [
Expand Down
Loading
Loading