Adjust public share authentication page to layout changes in NC25#7877
Merged
marcoambrosini merged 1 commit intoSep 9, 2022
Conversation
The content now has a fixed position to be always centered in the page. However, in order to add the Talk sidebar the content in the public share authentication page needs to be "pushed" to the left when the sidebar is added, so the content position needs to have a relative position instead (which also keeps the same appearance of the fixed position when the Talk sidebar is not shown yet). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
added
3. to review
bug
feature: frontend 🖌️
marcoambrosini
approved these changes
Sep 9, 2022
marcoambrosini
deleted the
adjust-public-share-authentication-page-to-layout-changes-in-nextcloud-25
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7852
The content now has a fixed position to be always centered in the page. However, in order to add the Talk sidebar the content in the public share authentication page needs to be "pushed" to the left when the sidebar is added, so the content position needs to have a relative position instead (which also keeps the same appearance of the fixed position when the Talk sidebar is not shown yet).