Convert print test from cypress to playwright #7940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
max-nextcloud
commented
Nov 14, 2025
max-nextcloud
commented
- convert print spec to playwright
- new File() with params object
- handle request token as part of login
- User class to wrap Account and Page
- print with shared file
- no need to merge randomUserTest
- remove superfluous cy print spec
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
max-nextcloud
force-pushed
the
chore/convert-cy-to-play
branch
2 times, most recently
from
6bd5c05 to
ec364ca
Compare
max-nextcloud
force-pushed
the
chore/convert-cy-to-play
branch
from
ec364ca to
364994c
Compare
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Preparing for multi context scenarios such as shared files. Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
It is included in uploadFileTest and sharedFileTest Signed-off-by: Max <[email protected]>
We have a playwright test that does the same now. Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Create a new instance on move to handle the name change Signed-off-by: Max <[email protected]>
max-nextcloud
force-pushed
the
chore/convert-cy-to-play
branch
2 times, most recently
from
9a2a819 to
28ac16c
Compare
For parameter properties see https://www.typescriptlang.org/docs/handbook/2/classes.html#parameter-properties For the lint exception see https://typescript-eslint.io/rules/no-useless-constructor/ Signed-off-by: Max <[email protected]>
Include a host identifier in the test name so the screenshot name also includes it. This way screenshots will only be compared to the ones created on the same machine. Only track the CI ones in git. Ignore the others. > Having different screenshots between local and docker environments is expected. > You can only compare screenshots that are taken in the same exact environment, OS, fonts, etc. See microsoft/playwright#20366 (comment) Signed-off-by: Max <[email protected]>
max-nextcloud
force-pushed
the
chore/convert-cy-to-play
branch
from
28ac16c to
ff1b7c8
Compare
benjaminfrueh
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.