Skip to content

Use LID fragment to access workflow output by name #6011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

bentsherman
Copy link
Member

  • Rename WorkflowRun -> WorkflowLaunch
  • Rename WorkflowOutput -> WorkflowRun
  • Use the WorkflowRun in the nextflow lineage list command
  • Remove TaskOutput since it is not used
  • Remove #output as a shortcut to access task/workflow outputs
  • Use LID fragment only to access workflow output by name
  • Remove the use of URL query syntax

Some miscellaneous improvements I made along the way:

  • Remove extraneous .meta subdirectory
  • Remove unused properties from data model

@bentsherman bentsherman requested a review from jorgee April 25, 2025 21:39
@bentsherman bentsherman marked this pull request as draft April 25, 2025 21:39
@bentsherman bentsherman marked this pull request as ready for review April 25, 2025 21:39
Copy link

netlify bot commented Apr 25, 2025

Deploy Preview for nextflow-docs-staging canceled.

Name Link
🔨 Latest commit 4e29bb8
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/680c01187057840008ec5602

@bentsherman
Copy link
Member Author

This PR removes a lot of unnecessary complexity around the LID filesystem that I feel is getting in the way of core use cases.

There are a few tests still failing, mainly because the view command now goes through LinPath instead of LinUtils.query() to resolve the LID, and it is currently trying to return the actual path of FileOutputs instead of the metadata description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant