Fix description for process config options with method overloads - #7442
Open
bentsherman wants to merge 1 commit into
Open
Fix description for process config options with method overloads#7442bentsherman wants to merge 1 commit into
bentsherman wants to merge 1 commit into
Conversation
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
✅ Deploy Preview for nextflow-docs canceled.
|
Member
Author
|
Related: nextflow-io/language-server#146 I am ironing out any non-deterministic LSP behavior so that I can reliably verify native vs JVM language server behavior |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix nextflow-io/language-server#173
This PR updates SpecNode to handle method overloads when loading process config from ProcessDsl
A process directive can have multiple overloads, but only one overload is expected to specify a description. So SpecNode needs to extract the description from whichever method defines it.