Upgrades to latest pyvroom, applies timeout#191
Open
merschformann wants to merge 2 commits intodevelopfrom
Open
Upgrades to latest pyvroom, applies timeout#191merschformann wants to merge 2 commits intodevelopfrom
merschformann wants to merge 2 commits intodevelopfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Python Pyvroom routing example to use the latest pyvroom release and wires the Nextmv duration option into VROOM’s solver call as a timeout.
Changes:
- Bump
pyvroomdependency from1.15.0to1.15.1. - Convert
input.options.duration(seconds) into atimedeltatimeout and pass it intoproblem_instance.solve().
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| python-pyvroom-routing/requirements.txt | Updates the pinned pyvroom version to 1.15.1. |
| python-pyvroom-routing/main.py | Implements timeout handling from input.options.duration and forwards it to VROOM’s solve(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sebastian-quintero
approved these changes
Apr 20, 2026
nmisek
approved these changes
Apr 21, 2026
Member
Author
|
For reference: this waits on a new release of pyvroom to incorporate VROOM-Project/pyvroom#141, or, removing the duration. 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upgrades to the latest pyvroom version and applies timeout as intended.