Skip to content

Remediate already ported bits [#1133]#1134

Merged
genehack merged 19 commits intomasterfrom
remediate-already-ported-bits-1133
Mar 24, 2025
Merged

Remediate already ported bits [#1133]#1134
genehack merged 19 commits intomasterfrom
remediate-already-ported-bits-1133

Conversation

@genehack
Copy link
Contributor

@genehack genehack commented Mar 21, 2025

Updates all the pages and components that had previously been ported to the App Router to use the standard JSDoc function documentation style.

Also adjusts some whitespace, and adds usage of the Metadata object to the /pathogens page, aligning it with other, similar pages.

Related issue(s)

#1133

Checklist

@nextstrain-bot nextstrain-bot temporarily deployed to nextstrain-s-remediate--zbivnz March 21, 2025 19:37 Inactive
@genehack genehack marked this pull request as ready for review March 21, 2025 22:53
@genehack genehack force-pushed the remediate-already-ported-bits-1133 branch from 495b694 to 1379814 Compare March 21, 2025 23:01
@genehack genehack temporarily deployed to nextstrain-s-remediate--zbivnz March 21, 2025 23:01 Inactive
@genehack
Copy link
Contributor Author

@victorlin Thanks for the detailed review! I have addressed all your comments.

Barring further input, I will plan to merge this early next week, immediately after #1131.

@genehack genehack mentioned this pull request Mar 21, 2025
2 tasks
@victorlin
Copy link
Member

I also plan to re-review #1131. It was on my list for this afternoon, but then this one came through and seemed like a smaller rock to fill the jar.

@genehack genehack force-pushed the convert-staging-to-app-router-1067 branch from ace67be to b281971 Compare March 24, 2025 19:44
Base automatically changed from convert-staging-to-app-router-1067 to master March 24, 2025 19:53
@genehack genehack force-pushed the remediate-already-ported-bits-1133 branch from 1379814 to b9ba905 Compare March 24, 2025 19:55
@genehack genehack temporarily deployed to nextstrain-s-remediate--zbivnz March 24, 2025 19:55 Inactive
@genehack genehack merged commit 6f5725a into master Mar 24, 2025
8 checks passed
@genehack genehack deleted the remediate-already-ported-bits-1133 branch March 24, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants