Merged
Conversation
victorlin
commented
Feb 27, 2026
Express' default error handler (finalhandler) always logs a full stack trace to stderr, even for expected client-side errors like 404s. This adds significant noise (10+ lines per error) to production server logs.
dda2aaa to
cf07c62
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Express' default error handler always logs a full stack trace to stderr, even for expected client-side errors like 404s. This adds significant noise (10+ lines per error) to production server logs.
Slack thread for context.
Checklist
Tested locally with
curl -I -X POST -H 'accept: text/html' http://localhost:5000/Before:
After:
Checks pass
Check if changes affect the resource index JSON revision