Skip to content

feat(plugins): add Design Taste Libraries router - #6194

Open
Baltsat wants to merge 15 commits into
nexu-io:mainfrom
Baltsat:plugin/design-taste-libraries-refresh-6193
Open

feat(plugins): add Design Taste Libraries router#6194
Baltsat wants to merge 15 commits into
nexu-io:mainfrom
Baltsat:plugin/design-taste-libraries-refresh-6193

Conversation

@Baltsat

@Baltsat Baltsat commented Jul 29, 2026

Copy link
Copy Markdown

Supersedes #4728, which was auto-closed for inactivity after its blocking code feedback was fixed and the corrected head was approved. It also supersedes #6193, an intermediate continuation that exposed a conflict with the newer community marketplace manifest. This PR recreates the same scoped contribution directly on the current main without that conflict.

Why

Open Design already has strong individual design systems and examples, but it lacks one opt-in routing step for choosing among them by surface before generation or critique. This plugin fills that workflow gap: it prefers existing Open Design coverage, adds external references only for genuine procedural gaps, and prevents agents from stacking unrelated taste libraries into generic output.

I wrote it while consolidating source-backed frontend, mobile, dashboard, shadcn, and motion guidance for repeated Open Design work. Without a router, the same brief can silently fall back to generic generation or duplicate capabilities already covered by Hallmark, shadcn, dashboard, mobile, Material, or HyperFrames plugins.

What users will see

After installing and applying community/design-taste-libraries, generation and critique runs first select one primary design library and at most two secondary references, state the chosen set and visual thesis, prefer matching built-in Open Design plugins, and run surface-specific proof checks before returning the artifact or critique. Surface defaults to web app; Brief can be supplied by an input-capable surface or falls back to the user's current request, attachments, and project context. Both values interpolate into the visible composer text. The runtime source index and selection matrix are embedded in the injected skill, so execution does not depend on discovering a staged side file. The plugin is opt-in and does not change existing users' default behavior.

Surface area

  • UI — new page / dialog / panel / menu item / setting / empty state in apps/web or apps/desktop (including Electron menu bar)
  • Keyboard shortcut — new or changed
  • CLI / env var — new od subcommand or flag, new tools-dev / tools-pack flag, or new OD_* env var
  • API / contract — new /api/* endpoint, new SSE event, or changed shape in packages/contracts
  • Extension point — adds an installable community plugin with a plugin-local SKILL.md router and reference catalog
  • i18n keys — added new translation keys
  • New top-level dependency — adds an entry to the root package.json
  • Default behavior change — the plugin is opt-in and affects only runs where it is installed and applied
  • None — internal refactor, docs, tests, or translation update only

Screenshots

Not applicable. This adds no new UI surface; discovery uses the existing Plugins Available marketplace UI.

Bug fix verification

Not applicable; this is a new community extension.

Validation

The router, catalog, and integration wiring derive from the corrected head previously approved on #4728. That review confirmed:

  • od.context.skills: [{ "path": "./SKILL.md" }] reaches the daemon's plugin-local skill loader;
  • references/LIBRARIES.md remains a staged asset rather than a skill reference;
  • the marketplace entry exposes community/design-taste-libraries with capabilitiesSummary: ["prompt:inject"];
  • targeted manifest checks and JSON parsing passed.

For this refreshed branch:

  • created directly from current upstream main (f52fda29a8a6fc65c501a45bb165b6f5208194a1), with that commit still the merge base and the branch 0 commits behind;
  • only four expected paths changed: SKILL.md, open-design.json, references/LIBRARIES.md, and the community marketplace manifest;
  • preserved the newer community/humanize-ppt registry entry and bumped both marketplace version fields from 0.2.3 to 0.2.4;
  • normalized the manifest to current community conventions: community-design-taste-libraries, community tag, author URL, and homepage;
  • re-audited the catalog against current plugin manifests, removed the deleted example-cinematic-landing-page reference, and replaced it with registered HyperFrames/motion examples;
  • repaired moved dashboard and Expo Native UI paths, then replaced intermediary catalog URLs with canonical GitHub SKILL.md sources;
  • embedded the operative source index and surface selection matrix directly in SKILL.md; references/LIBRARIES.md is provenance-only, so runtime no longer searches wildcard staged aliases or risks opening a stale copy;
  • interpolated {{surface}} and {{brief}} into the visible use-case query;
  • kept inputless attach/apply paths working by giving surface and brief schema defaults; PluginsSection seeds those defaults before renderPluginBriefTemplate;
  • answered and resolved all six Codex review threads;
  • current-head Codex review on 7f917e2 found no major issues;
  • verified one community/design-taste-libraries marketplace entry, plugin-local skill injection, reference asset path, and prompt:inject capability;
  • GitHub currently reports the PR mergeable.

Full repository guard/typecheck is waiting for the upstream maintainer to approve fork workflows; this PR changes no runtime code or dependencies.

Copilot AI review requested due to automatic review settings July 29, 2026 01:47

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Baltsat commented Jul 29, 2026

Copy link
Copy Markdown
Author

@lefarcen @PerishCode this is the conflict-free continuation of #4728 on current main.

The original blocking integration fixes are preserved, the PR-template feedback is complete, and the community registry refresh preserves community/humanize-ppt while bumping the seed to 0.2.4.

All six Codex findings on the refreshed branch have been addressed and their threads resolved:

  • the operative source index and selection matrix live directly in SKILL.md, so runtime cannot select a stale staged catalog copy;
  • the deleted cinematic example ID was replaced with registered motion examples;
  • Surface and Brief interpolate into the visible composer brief;
  • inputless attach/apply remains supported through schema defaults;
  • moved dashboard/Expo links and intermediary catalog URLs were replaced with canonical GitHub sources.

Current-head Codex review on 7f917e2 found no major issues. GitHub reports the PR mergeable, exactly four changed paths, and 0 commits behind current main.

Only upstream gates remain:

  1. Approve and run workflows — the repository's trusted auto-approver intentionally excludes plugins/**, so all three runs are action_required with zero jobs started.
  2. Human approval and merge after CI passes.

@lefarcen

Copy link
Copy Markdown
Contributor

Thanks @Baltsat — carrying the #4728/#6193 continuation onto current main and keeping the marketplace manifest update in sync is helpful. I’m routing this through pool review now.

💡 To drive this PR to merge hands-free, paste this to your AI coding agent (Claude Code / Codex / opencode / Cursor …):
Take over nexu-io/open-design#6194 until it merges — read https://raw.githubusercontent.com/nexu-io/looper/main/skills/pr-takeover/SKILL.md and follow it.

@lefarcen
lefarcen requested a review from PerishCode July 29, 2026 01:51
@lefarcen lefarcen added size/L PR changes 300-700 lines risk/medium Medium risk: regular code changes type/feature New feature labels Jul 29, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c93a16300a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread plugins/community/design-taste-libraries/SKILL.md Outdated
Comment thread plugins/community/design-taste-libraries/references/LIBRARIES.md Outdated
@lefarcen

Copy link
Copy Markdown
Contributor

Thanks for the refresh and for normalizing the manifest to the current community conventions. Noted on head 4582e88 — this is still waiting on the fresh pool-review pass, and the fork workflow approval will need to be cleared before that run can fully proceed.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: feabaa011c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread plugins/community/design-taste-libraries/open-design.json Outdated

Baltsat commented Jul 29, 2026

Copy link
Copy Markdown
Author

@codex review

Please review current head aea642b, focusing on the staged catalog path, input interpolation, manifest/marketplace consistency, and any remaining broken local or external references.

Baltsat commented Jul 29, 2026

Copy link
Copy Markdown
Author

@codex review

Please review current head b3ddec9. Previous P1/P2 threads are fixed and resolved; focus on any remaining correctness issue in plugin-local skill staging, input rendering, manifest/marketplace identity, and catalog references. The staged lookup is now scoped to .od-skills/design-taste-libraries-*/... to avoid selecting another skill.

Baltsat commented Jul 29, 2026

Copy link
Copy Markdown
Author

@lefarcen confirmed the repository's scripts/approve-fork-pr-workflows.ts intentionally does not allowlist plugins/** changes, so the trusted auto-approval workflow will skip this PR. The current action_required runs therefore need a maintainer to click Approve and run workflows manually for head 7f917e2; there are no jobs or failure logs yet.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b5385b1b58

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread plugins/community/design-taste-libraries/open-design.json Outdated

Baltsat commented Jul 29, 2026

Copy link
Copy Markdown
Author

@codex review

Current head is b3ddec9. Please review the final four-file diff; all earlier threads are resolved.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b3ddec90db

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread plugins/community/design-taste-libraries/SKILL.md Outdated

Baltsat commented Jul 29, 2026

Copy link
Copy Markdown
Author

@codex review

Current head is c2c738a. The latest P2 was fixed by making brief optional with a schema default; all four review threads are resolved. Please review the final four-file diff.

Baltsat commented Jul 29, 2026

Copy link
Copy Markdown
Author

@codex review

Current head is 978c202. The latest P1 was fixed by matching both marketplace and local-source staged directory names. All five review threads are resolved; please review the final four-file diff.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 978c202888

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread plugins/community/design-taste-libraries/SKILL.md Outdated

Baltsat commented Jul 29, 2026

Copy link
Copy Markdown
Author

@codex review

Current head is 7f917e2. The latest P2 was fixed by removing runtime staged-catalog discovery entirely and embedding the authoritative source index plus selection matrix in SKILL.md. All six review threads are resolved; please review the final four-file diff.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: 7f917e2075

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@PerishCode PerishCode left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Baltsat I reviewed all four changed files on the current head, including the plugin manifest and marketplace identity, input defaults and interpolation, the embedded runtime routing matrix, local plugin references, and the provenance catalog. The earlier staged-catalog and reference issues are resolved, and the plugin-runtime typecheck passes. This is a thoughtful, well-contained addition—thanks for carrying the fixes through and keeping the community registry refresh consistent.

🔁 Powered by Looper · runner=reviewer · agent=codex · An autonomous AI dev team for your GitHub repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk/medium Medium risk: regular code changes size/L PR changes 300-700 lines type/feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants