Use start.elapsed() instead of last_tick.elapsed() in Timer#425
Open
MozirDmitriy wants to merge 1 commit intonexus-xyz:mainfrom
Open
Use start.elapsed() instead of last_tick.elapsed() in Timer#425MozirDmitriy wants to merge 1 commit intonexus-xyz:mainfrom
MozirDmitriy wants to merge 1 commit intonexus-xyz:mainfrom
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
|
Thanks for the PR! At the moment the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced the use of last_tick.elapsed() with start.elapsed() in the Timer component's draw_unchecked method.
This change ensures that the timer always displays the total elapsed time since the timer started, which matches typical user expectations for progress indicators.
Previously, last_tick was not updated anywhere except during initialization and finalize, so its use could be misleading and did not provide any additional value.
Using start.elapsed() makes the code simpler, more transparent, and consistent with how elapsed time is calculated elsewhere in the codebase.