fix: fix timer in Update timer.rs#439
Closed
HarleyQeen wants to merge 1 commit intonexus-xyz:mainfrom
Closed
Conversation
The Timer component was using a last_tick field to compute elapsed time, which was only initialized in new() and never updated during normal execution. This caused the timer to always display the same duration instead of the actual time since the action began. Fix: Removed the unused last_tick field. Replaced last_tick.elapsed() with start.elapsed() to correctly reflect time since the action started. Simplified the logic in finalize() by removing unnecessary state reset. Why: start.elapsed() is sufficient for showing total elapsed time, and avoids redundant state tracking. This change makes the timer behave as expected and keeps the code cleaner.
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
Contributor
|
Duplicate of #425 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Timer component was using a last_tick field to compute elapsed time, which was only initialized in new() and never updated during normal execution. This caused the timer to always display the same duration instead of the actual time since the action began.
Fix:
Removed the unused last_tick field.
Replaced last_tick.elapsed() with start.elapsed() to correctly reflect time since the action started.
Simplified the logic in finalize() by removing unnecessary state reset.
Why:
start.elapsed() is sufficient for showing total elapsed time, and avoids redundant state tracking. This change makes the timer behave as expected and keeps the code cleaner.