Progress bar: fix fill calculation to avoid premature 100% display#482
Open
viktorking7 wants to merge 1 commit intonexus-xyz:mainfrom
Open
Progress bar: fix fill calculation to avoid premature 100% display#482viktorking7 wants to merge 1 commit intonexus-xyz:mainfrom
viktorking7 wants to merge 1 commit intonexus-xyz:mainfrom
Conversation
Contributor
|
Thanks for the PR. At the moment the cli crate is more of a temporary patch, as we plan in the long-term to incorporate direct zkVM usage with the more general https://github.com/nexus-xyz/nexus-cli project. I'm going to leave this PR open because we might at some point bring the progress-bar over into the project and this may be a useful reference, but for the time being I'm going to leave the crate frozen. |
SashaMalysehko
pushed a commit
to SashaMalysehko/nexus-zkvm
that referenced
this pull request
Dec 9, 2025
* Add and range-check Is{Ecall, Ebreak} columns
* IsTypeSys virtual column
* Add empty TypeSysChip for decoding
* Decode ecall and ebreak instructions
* Apply suggestions from code review
Co-authored-by: duc-nx <duc@nexus.xyz>
---------
Co-authored-by: duc-nx <duc@nexus.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct the progress bar fill logic to prevent showing a full bar before the final step completes.
Changes
WIDTH - 1while not finished.Why
Avoids misleading UX where the bar appears complete one step too early.