Skip to content

Progress bar: fix fill calculation to avoid premature 100% display #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
viktorking7 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Progress bar: fix fill calculation to avoid premature 100% display #482

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion cli/progress-bar/src/component/loading.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,12 @@ impl Component for LoadingBar<'_> {
)?;

let percentage = iteration as f64 / total as f64;
let amount = (percentage * WIDTH as f64).ceil() as usize;
// Use floor to avoid prematurely showing a full bar before completion.
// Clamp to WIDTH - 1 while not finished to keep visual consistency.
let mut amount = (percentage * WIDTH as f64).floor() as usize;
if !action.is_finished() {
amount = amount.min(WIDTH.saturating_sub(1));
}

let loading_bar = format!(
" [{test:=>bar_amt$}{empty:padding_amt$}] {}/{}: ...",
Expand Down